Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global tech preview indicator for service catalog #1712

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Global tech preview indicator for service catalog #1712

merged 1 commit into from
Jun 26, 2017

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Jun 14, 2017

Fixes #1699

Following the design direction set by the page-level "Technology Preview" badge, how about an orange bar above the navbar? Exact message wording to be determined.

screen shot 2017-06-15 at 10 27 00 am
screen shot 2017-06-15 at 10 26 23 am

screen shot 2017-06-15 at 10 29 02 am
screen shot 2017-06-15 at 10 29 39 am

@rhamilto
Copy link
Member Author

@sspeiche, @jwforres says to ping you on this...

@sspeiche
Copy link

Seems fine to me. I could see someone getting annoyed with it and perhaps wanting to dismiss it.

As far as the wording, I think the wording is fine if the text linked out to somewhere that described what was tech preview. Though I could see 2 different things being tech preview: 1. the UI/UX and 2. the underlying service catalog (and brokers). It might be handy to know when it is one or both.

@rhamilto
Copy link
Member Author

Seems fine to me. I could see someone getting annoyed with it and perhaps wanting to dismiss it.

Per @jwforres, we sort of want it to be annoying as we will not be supporting service catalog in tech preview and do not want it to be overlooked.

As far as the wording, I think the wording is fine if the text linked out to somewhere that described what was tech preview. Though I could see 2 different things being tech preview: 1. the UI/UX and 2. the underlying service catalog (and brokers). It might be handy to know when it is one or both

Adding a link is easy. What it links to is the hard part. Who is to create the documentation and where does it live?

@rhamilto rhamilto changed the title [WIP] exploring global tech preview indicator ideas Global tech preview indicator for service catalog Jun 21, 2017
@rhamilto rhamilto requested a review from jwforres June 21, 2017 14:29
@rhamilto
Copy link
Member Author

Gonna go ahead and request review and merge on this with the understanding we'll possibly add a follow on to add a link.

@jwforres
Copy link
Member

LGTM but don't think this qualifies for a blocker, would rather hold it till monday

@jwforres
Copy link
Member

[merge]

1 similar comment
@jwforres
Copy link
Member

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 1c80c6b

@openshift-bot
Copy link

openshift-bot commented Jun 26, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1584/) (Base Commit: 066938a) (PR Branch Commit: 1c80c6b)

@openshift-bot openshift-bot merged commit d0e24f5 into openshift:master Jun 26, 2017
@rhamilto rhamilto deleted the issue-1699 branch June 26, 2017 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants