Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine secrets page tables into one and group by type. #1717

Merged
merged 1 commit into from
Jun 15, 2017

Conversation

sg00dwin
Copy link
Member

@spadgett
Copy link
Member

@jwforres better for you to review since I worked with @sg00dwin on this

@spadgett spadgett requested a review from jwforres June 15, 2017 16:26
@jwforres
Copy link
Member

[merge]

@spadgett
Copy link
Member

spadgett commented Jun 15, 2017

[merge][severity: bug]

@jwforres
Copy link
Member

not sure what will happen here since your comment timestamp is before the failure was reported
you also had a space before bug in your tag..

[merge][severity:bug]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 3eb5fc0

@openshift-bot
Copy link

openshift-bot commented Jun 15, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1540/) (Base Commit: 6e95ce2) (PR Branch Commit: 3eb5fc0) (Extended Tests: bug)

@openshift-bot openshift-bot merged commit 1a99033 into openshift:master Jun 15, 2017
@sg00dwin sg00dwin deleted the empty-message-issue1686 branch June 16, 2017 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants