Don't show new builds in collapsed overview rows #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwforres
reviewed
Jun 15, 2017
app/scripts/services/builds.js
Outdated
| var displayName = getBuildDisplayName(build, buildConfig.metadata.name); | ||
| var runPolicy = _.get(buildConfig, 'spec.runPolicy'); | ||
| if (runPolicy === 'Serial' || runPolicy === 'SerialLatestOnly') { | ||
| details = "The build has been queued with run policy " + camelToLower(runPolicy) + "."; |
There was a problem hiding this comment.
sentence seems like it reads strangely to me
maybe "This build has been queued under a serial run policy." and not worry about the distinction between serial and serial latest only? The important thing is that its not parallel.
alternatively "This build is configured to run serially and has been added to the queue."
spadgett
force-pushed
the
overview-new-builds
branch
from
81ca713
to
b28785b
Compare
|
updated |
jwforres
reviewed
Jun 15, 2017
app/scripts/services/builds.js
Outdated
| if (runPolicy === 'Serial' || runPolicy === 'SerialLatestOnly') { | ||
| message = _.capitalize(buildType) + " " + displayName + " successfully queued."; | ||
| details = "Builds for " + buildConfig.metadata.name + " are configured to run one at a time."; | ||
| // details = "This build has been configured to run serially and has been added to the queue."; |
Only show Pending, Running, Failed, and Error in the collapsed row. Don't show new builds, but update the toast notification to say that the build is queued.
spadgett
force-pushed
the
overview-new-builds
branch
from
b28785b
to
7acebf8
Compare
|
Comment removed, thanks |
jwforres
approved these changes
Jun 15, 2017
|
[merge][severity:bug] |
|
Evaluated for origin web console merge up to 7acebf8 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1550/) (Base Commit: c0d9ac2) (PR Branch Commit: 7acebf8) (Extended Tests: bug) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only show Pending, Running, Failed, and Error in the collapsed row.
Don't show new builds, but update the toast notification to say that the
build is queued.
Fixes #1687