Bug 1460990 - show underlying username in several places where user may look #1724
Conversation
|
|
|
open to other suggestions |
|
Does the logout menu grow wider if the ID is something long like an email address? Screenshots look good. |
|
Yeah the menu seems to fit to the content |
|
Suggest we only show in the menu if it's different than what we show in the banner already. |
jwforres
force-pushed
the
bug-1460990-user-acct-name
branch
from
20af7f5
to
101afa6
Compare
|
updated to only show it in logout if fullName exists and is different |
| return [{ | ||
| type: 'dom', | ||
| node: '<li><a href="logout">Log out</a></li>' | ||
| node: '<li><a href="logout">' + msg + '</a></li>' |
jwforres
force-pushed
the
bug-1460990-user-acct-name
branch
from
101afa6
to
fe7d927
Compare
jwforres
force-pushed
the
bug-1460990-user-acct-name
branch
from
fe7d927
to
697d6f4
Compare
|
[merge][severity: blocker] |
|
Evaluated for origin web console merge up to 697d6f4 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin web console test up to 697d6f4 |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1545/) (Base Commit: 1a99033) (PR Branch Commit: 697d6f4) |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1549/) (Base Commit: fa07799) (PR Branch Commit: 697d6f4) (Extended Tests: blocker) |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1460990