Add link to controller on pod and replica set pages #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the following links to the detail pages in the console using controller references: * pod -> replication controller (not part of deployment config) * pod -> replica set * pod -> build * replica set -> deployment We previously added a link to deployment configs using pod and replication controller labels.
jwforres
reviewed
Jun 19, 2017
| if (!$scope.dcName) { | ||
| var controllerReferences = OwnerReferencesService.getControllerReferences(pod); | ||
| $scope.controllerRef = _.find(controllerReferences, function(ref) { | ||
| return ref.kind === 'ReplicationController' || |
There was a problem hiding this comment.
what does the owner ref on the deployer pod look like?
There was a problem hiding this comment.
It's not a controller ref so won't show up.
ownerReferences:
- apiVersion: v1
kind: ReplicationController
name: hello-openshift-2
uid: e567f54d-5541-11e7-90d1-9e0e2b8a4114
jwforres
approved these changes
Jun 20, 2017
|
[merge][severity:bug] |
|
Evaluated for origin web console merge up to abf8ca9 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1569/) (Base Commit: 0bdb929) (PR Branch Commit: abf8ca9) (Extended Tests: bug) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following links to the detail pages in the console using
controller references:
We previously added a link to deployment configs using pod and
replication controller labels.