Make it easier to discover enabling TLS for routes #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwforres
reviewed
Jun 23, 2017
app/views/browse/route.html
Outdated
| <p ng-if="!route.spec.tls"> | ||
| TLS is not enabled. | ||
| <span ng-if="'routes' | canI : 'update'"> | ||
| <a ng-href="{{route | editResourceURL}}" role="button">Edit</a> this route to enable security. |
There was a problem hiding this comment.
maybe "Edit this route to enable secure network traffic" or something instead of just "security"
Add an "Edit this route to enable security" link under the TLS section if TLS is not enabled.
spadgett
force-pushed
the
edit-route-link
branch
from
e0cfb39
to
dd1b554
Compare
|
updated |
jwforres
approved these changes
Jun 23, 2017
|
can merge when queue re-opens |
|
[merge] |
|
Evaluated for origin web console merge up to dd1b554 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin web console test up to dd1b554 |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1591/) (Base Commit: d0e24f5) (PR Branch Commit: dd1b554) |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1595/) (Base Commit: 2a22355) (PR Branch Commit: dd1b554) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an "Edit this route to enable security" link under the TLS section if TLS is not enabled.
See #1760
cc @Kargakis