Don't request instances and bindings if the user doesn't have watch rights #1769
Conversation
|
FYI @spadgett viewers won't be able to see instances/bindings for tech preview because of the concerns around params containing secret info |
| @@ -1349,7 +1349,9 @@ function OverviewController($scope, | |||
| updateQuotaWarnings(); | |||
| }, {poll: true, pollInterval: DEFAULT_POLL_INTERVAL})); | |||
|
|
|||
| if (SERVICE_CATALOG_ENABLED) { | |||
| var canI = $filter('canI'); | |||
| // The canI check on watch should be temporary until we have a different solution for handling secret parameters | |||
There was a problem hiding this comment.
Curious (my own ignorance) how changing what we do for handling secret parameters will help with this watch on instances? Not saying the comment needs more necessarily, I just don't know that I follow.
There was a problem hiding this comment.
We want instances to be watchable by project viewers, once they are then this check isn't really necessary, we dont have this check for any of the other watches today. We can't make them watchable (or listable) by project viewers yet because of the way parameters are are currently stored on instances and bindings. Viewers today should not be allowed to see potentially confidential information.
|
travis passed, the dist is correct, the local variable minification in the overview code changed because i added a new variable [merge] |
|
Evaluated for origin web console merge up to 85b5d7f |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1600/) (Base Commit: 26d468a) (PR Branch Commit: 85b5d7f) |
No description provided.