Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oc <= 1.0.4 defaults to v1beta3 #5254

Closed
liggitt opened this issue Oct 20, 2015 · 4 comments · Fixed by openshift/openshift-docs#1134
Closed

oc <= 1.0.4 defaults to v1beta3 #5254

liggitt opened this issue Oct 20, 2015 · 4 comments · Fixed by openshift/openshift-docs#1134

Comments

@liggitt
Copy link
Contributor

liggitt commented Oct 20, 2015

Found when using older oc clients after removing v1beta3 from master

Clients 1.0.4 and earlier are defaulting to v1beta3

$ oc get projects --token=... --server=https://localhost:8443 --loglevel=8
I1020 13:42:02.326013   27447 debugging.go:98] GET https://localhost:8443/osapi/v1beta3/projects
I1020 13:42:02.326065   27447 debugging.go:105] Request Headers:
I1020 13:42:02.326073   27447 debugging.go:108]     User-Agent: oc/v1.0.4 (linux/amd64) openshift/757efd9

Working versions: 1.0.5+
Broken versions: 1.0.4 and below

Passing --api-version=v1 allows these clients to talk to a v1 server.

We should:

  1. Document how to make older clients work with v1
  2. Ensure current code is doing negotiate, not hard-coding v1

cc @mfojtik

@mfojtik
Copy link
Contributor

mfojtik commented Oct 20, 2015

so I was not crazy, thanks @liggitt !
On Oct 20, 2015 7:45 PM, "Jordan Liggitt" notifications@github.com wrote:

Found when using older oc clients after removing v1beta3 from master

Clients 1.0.4 and earlier are defaulting to v1beta3

$ oc get projects --token=... --server=https://localhost:8443 --loglevel=8
I1020 13:42:02.326013 27447 debugging.go:98] GET https://localhost:8443/osapi/v1beta3/projects
I1020 https://localhost:8443/osapi/v1beta3/projectsI1020 13:42:02.326065 27447 debugging.go:105] Request Headers:
I1020 13:42:02.326073 27447 debugging.go:108] User-Agent: oc/v1.0.4 (linux/amd64) openshift/757efd9

Working versions: 1.0.5+
Broken versions: 1.0.4 and below

Passing --api-version=v1 allows these clients to talk to a v1 server.

We should:

  1. Document how to make older clients work with v1
  2. Ensure current code is doing negotiate, not hard-coding v1

cc @mfojtik https://github.com/mfojtik


Reply to this email directly or view it on GitHub
#5254.

@liggitt liggitt changed the title oc running without kubeconfig uses different API defaults oc <= 1.0.4 defaults to v1beta3 Oct 22, 2015
@jwforres jwforres added this to the 1.1.0 milestone Nov 2, 2015
@jwforres
Copy link
Member

jwforres commented Nov 2, 2015

Purely a documentation issue, nothing else can be done for this.

@fabianofranz
Copy link
Member

Adding documentation notes here: openshift/openshift-docs#1134

@liggitt
Copy link
Contributor Author

liggitt commented Nov 4, 2015

@liggitt liggitt closed this as completed Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants