Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stale SDN code: Writing cluster network CIDR to config.env #13726

Merged
merged 1 commit into from
Jun 15, 2017
Merged

Remove stale SDN code: Writing cluster network CIDR to config.env #13726

merged 1 commit into from
Jun 15, 2017

Conversation

pravisankar
Copy link

/run/openshift-sdn/config.env was used in F5 ramp node.
Now F5 doesn't use ramp node any more so this change is not needed.

@pravisankar
Copy link
Author

@openshift/networking PTAL

@pravisankar
Copy link
Author

[test]

@danwinship
Copy link
Contributor

Now F5 doesn't use ramp node any more

We don't require using a ramp node... but do we actually forbid it? What happens if someone with an existing cluster with ramp nodes upgrades to OpenShift 3.6? Will they end up with ramp nodes that no longer work because config.env is missing? Or do we already force people to migrate away from ramp nodes when upgrading to a newer version of OpenShift?

@dcbw
Copy link
Contributor

dcbw commented Apr 12, 2017

Yeah, upgrade is the only issue here. Otherwise LGTM.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2017
@openshift-bot openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 6, 2017
@knobunc
Copy link
Contributor

knobunc commented May 8, 2017

We don't forbid ramp nodes... and there's no doc yet, unless @rajatchopra knows otherwise, telling people how to migrate. And we don't do it in the installer... so I don't think we can use this yet.

@openshift-bot openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 20, 2017
@rajatchopra
Copy link
Contributor

We don't forbid ramp nodes... and there's no doc yet, unless @rajatchopra knows otherwise, telling people how to migrate. And we don't do it in the installer... so I don't think we can use this yet.

This should be PM's discretion. I want to forbid it, though we do not do it yet.
Either way, the contents of the config file are static. We can ask the user to learn the contents from apiserver too (oc get clusternetwork), how about we remove the file and update the docs?

@danwinship
Copy link
Contributor

how about we remove the file and update the docs?

I'd be OK with that. I guess on nodes that already have the file, it's not going to get deleted by anything, so they should keep working as long as the HostSubnet doesn't change (which it shouldn't).

@pravisankar pravisankar mentioned this pull request Jun 13, 2017
Merged
4 tasks
knobunc
knobunc approved these changes Jun 13, 2017
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Remove stale SDN code: Writing cluster network CIDR to config.env
6306dcb 
/run/openshift-sdn/config.env was used in F5 ramp node.
Now F5 doesn't use ramp node any more so this change is not needed.
@pravisankar
Copy link
Author

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 6306dcb

@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2017
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2194/) (Base Commit: 599a720)

@pravisankar
Copy link
Author

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 14, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 11

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 6306dcb

@smarterclayton smarterclayton merged commit a7de403 into openshift:master Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc knobunc approved these changes

Assignees
No one assigned
Labels
component/networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pravisankar @danwinship @dcbw @knobunc @rajatchopra @openshift-bot @smarterclayton