Add NormalizePolicyRules to authorizationsync #14475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 5, 2017
|
lgtm, but fix your cache mutation problem here: https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1933/ |
deads2k
reviewed
Jun 6, 2017
| @@ -75,6 +75,9 @@ func (c *OriginClusterRoleToRBACClusterRoleController) syncClusterRole(name stri | |||
| return c.rbacClient.ClusterRoles().Delete(name, nil) | |||
| } | |||
|
|
|||
| // normalize rules before conversion so RBAC's case sensitive authorizer will work | |||
| NormalizePolicyRules(originClusterRole.Rules) | |||
There was a problem hiding this comment.
This is mutating a cache. Seems like you'd do this on the RBAC rule after you converted and copied.
NormalizePolicyRules lowercases APIGroups, Verbs and Resources. By using it before persistence, all RBAC roles will work with Kubernetes' case sensitive authorizer. Signed-off-by: Monis Khan <mkhan@redhat.com>
enj
force-pushed
the
enj/i/normalize_policy_controllers/13429
branch
from
96125e0
to
84385aa
Compare
|
Evaluated for origin test up to 84385aa |
|
@deads2k cache mutation should be fixed now. |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1985/) (Base Commit: 6a2194d) |
|
Flake #14496 |
|
Evaluated for origin merge up to 84385aa |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/947/) (Base Commit: cf830c4) (Image: devenv-rhel7_6338) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NormalizePolicyRuleslowercasesAPIGroups,VerbsandResources. By using it before persistence, all RBAC roles will work with Kubernetes' case sensitive authorizer.Fixes #13429
Supersedes #14410
[test]
Signed-off-by: Monis Khan mkhan@redhat.com
cc @deads2k