UPSTREAM: 47078: HPA: only send updates when the status has changed #14529
Conversation
|
[test] |
1 similar comment
|
[test] |
|
at a glance, these seem to all be flakes. |
|
[merge][severity:blocker] |
|
re [test] |
1 similar comment
|
re [test] |
|
whoops, looks like there's a newly detected race in horizontal_test.go that wasn't showing up before. It was buried in the middle of the unit test results, as it doesn't actually cause the unit tests to fail :-/. |
This commit only sends updates if the status has actually changed. Since the HPA runs at a regular interval, this should reduce the volume of writes, especially on short HPA intervals with relatively constant metrics.
DirectXMan12
force-pushed
the
cherry-pick/hpa-status-updates
branch
from
754696d
to
20c087f
Compare
|
ok, that should fix it. |
|
Evaluated for origin test up to 20c087f |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2895/) (Base Commit: 57a4d50) (PR Branch Commit: 20c087f) |
|
[merge][severity:blocker] |
|
[merge] because i don't see events anywhere in the timeout... |
|
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 1 |
|
[merge][severity:blocker] as last failure was due to timeout provisioning cluster. |
|
Evaluated for origin merge up to 20c087f |
This commit only sends updates if the status has actually changed.
Since the HPA runs at a regular interval, this should reduce the volume
of writes, especially on short HPA intervals with relatively constant
metrics.
bug 1467022