Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When sorting SCCs by restrictions don't add a score if SCC allows volumes of projected type #14548

Merged
merged 1 commit into from
Jun 20, 2017
Merged

When sorting SCCs by restrictions don't add a score if SCC allows volumes of projected type #14548

merged 1 commit into from
Jun 20, 2017

Conversation

php-coder
Copy link
Contributor

@php-coder php-coder commented Jun 9, 2017 •
edited
Loading

After adding projected type to many of our SCCs in #14147, we accidentally changed their score. This PR corrects that by treating projected volume type as a trivial (that has a score of 0).

PTAL @pweil-
CC @mfojtik
JFYI @jpeeler

@php-coder php-coder requested a review from pweil- June 9, 2017 14:26
pweil-
pweil- approved these changes Jun 9, 2017
View reviewed changes
Copy link
Contributor

@pweil- pweil- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@php-coder
Copy link
Contributor Author

@mfojtik Can we merge it or we're in the code freeze?

@mfojtik
Copy link
Contributor

mfojtik commented Jun 12, 2017

LGTM [merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@php-coder
Copy link
Contributor Author

Test flake #10773
Test flake #13829

@php-coder
Copy link
Contributor Author

@mfojtik Could you try to merge it again?

@mfojtik
Copy link
Contributor

mfojtik commented Jun 14, 2017

[merge]

@php-coder
Copy link
Contributor Author

Huh... "Branch is Closed for Non-Bugs"

@mfojtik
Copy link
Contributor

mfojtik commented Jun 15, 2017

[severity:bug]

@pweil-
Copy link
Contributor

pweil- commented Jun 19, 2017

@php-coder conflict with kapi.FSTypeNone please update 😄

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2017
@php-coder php-coder force-pushed the scc_prioritization_and_projected_type branch from ea0b3d8 to b79d723 Compare June 19, 2017 12:44
@php-coder
Copy link
Contributor Author

Updated (and also I've added a missing test for kapi.FSTypeNone). PTAL.

pweil-
pweil- reviewed Jun 19, 2017
View reviewed changes
Copy link
Contributor

@pweil- pweil- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to b79d723

@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2017
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2388/) (Base Commit: 5dce9b9) (PR Branch Commit: b79d723)

@php-coder
Copy link
Contributor Author

@pweil- @mfojtik Merge?

@pweil-
Copy link
Contributor

pweil- commented Jun 20, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to b79d723

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 20, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1053/) (Base Commit: a513a2b) (PR Branch Commit: b79d723) (Extended Tests: bug) (Image: devenv-rhel7_6381)

@openshift-bot openshift-bot merged commit 26a56a3 into openshift:master Jun 20, 2017
@php-coder php-coder deleted the scc_prioritization_and_projected_type branch June 20, 2017 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pweil- pweil- pweil- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@php-coder @mfojtik @openshift-bot @pweil-