Remove ImageStreamReferenceIndex from BuildInformer

[csrwng]

The ImageStreamReferenceIndex doesn't apply to builds. Removes that index from the builds informer.

[csrwng]

@bparees this was the issue with the index. I copied this code from the BuildConfig informer and included an index that would always return an error for builds. Because this index function returned an error, if it was the first index to be processed for a particular build, the other index for the namespace wasn't getting processed either. In upstream, maybe the right behavior would be to log the error and continue instead of returning:
https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/thread_safe_store.go#L252
/cc @deads2k
The result is that we were getting some entries in the cache that were not in the namespace index

[csrwng]

[test]

[deads2k]

In upstream, maybe the right behavior would be to log the error and continue instead of returning:

Since there is already a lack of compensation for partially inserted keys, aggregating all the errors together seems reasonable. I'd probably suggest logging it using utilruntime.HandleError higher up the stack.

[deads2k]

Oh, also, you should switch to the generated informers.

[openshift-bot]

Evaluated for origin test up to e65b77b

[bparees]

Oh, also, you should switch to the generated informers.

yeah my understanding is @smarterclayton is planning to do that wholesale for all our controllers shortly.

[bparees]

[testextended][extended:core(builds)]

[bparees]

@csrwng do you want to include re-enabling the cache for pruning w/ this PR then?

[csrwng]

@csrwng do you want to include re-enabling the cache for pruning w/ this PR then?

I'd rather not have too many dependencies. This PR can go in without requiring the other ones.
I'll create a separate one for re-enabling the cache.

[bparees]

I'd rather not have too many dependencies. This PR can go in without requiring the other ones.
I'll create a separate one for re-enabling the cache.

k

[bparees]

lgtm pending passing extended tests

[openshift-bot]

Evaluated for origin testextended up to e65b77b

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2208/) (Base Commit: 653b218)

[openshift-bot]

continuous-integration/openshift-jenkins/testextended FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/625/) (Base Commit: 653b218) (Extended Tests: core(builds))

[csrwng]

extended test failures are known flakes
[merge][severity:bug]

[openshift-bot]

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 6

[openshift-bot]

Evaluated for origin merge up to e65b77b