Add DefaultIOAccounting to all openshift services #14644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/openshift/origin/blob/master/origin.spec#L535 Update this to ensure that it's applied on rpm upgrade immediately |
|
Also, not sure we're actually applying this for containerized installs. I need to look into that. |
|
@smarterclayton - whats the cost of turning this on? @jeremyeder do you know? |
|
I don't, but will ask around. There are zero useful hits on Google for DefaultIOAccounting=yes. |
|
@smarterclayton @derekwaynecarr have you tested this? Does it actually work? Is it possibly DefaultBlockIOAccounting? |
|
it replaces the block io accounting setting, so i imagine the behavior is
similar.
https://www.freedesktop.org/software/systemd/man/systemd.resource-control.html#IOAccounting=
…On Wed, Jun 14, 2017 at 4:56 PM, Jeremy Eder ***@***.***> wrote:
@smarterclayton <https://github.com/smarterclayton> @derekwaynecarr
<https://github.com/derekwaynecarr> have you tested this? Does it
actually work? Is it possibly DefaultBlockIOAccounting?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14644 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF8dbPXn7ft7sq0fgTXq8rl5zDLy2Qqhks5sEEjigaJpZM4N6J7n>
.
|
|
We turn it on for all containers, so I don't know that enabling it for a
few extra services is an issue.
On Wed, Jun 14, 2017 at 5:13 PM, Derek Carr <notifications@github.com>
wrote:
… it replaces the block io accounting setting, so i imagine the behavior is
similar.
https://www.freedesktop.org/software/systemd/man/systemd.
resource-control.html#IOAccounting=
On Wed, Jun 14, 2017 at 4:56 PM, Jeremy Eder ***@***.***>
wrote:
> @smarterclayton <https://github.com/smarterclayton> @derekwaynecarr
> <https://github.com/derekwaynecarr> have you tested this? Does it
> actually work? Is it possibly DefaultBlockIOAccounting?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#14644 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
AF8dbPXn7ft7sq0fgTXq8rl5zDLy2Qqhks5sEEjigaJpZM4N6J7n>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14644 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p2M4bCiaCQTu35ljBE34lrL8GPKYks5sEEzugaJpZM4N6J7n>
.
|
|
I don't think that option wasn't added until systemd v230. Have you verified it does anything on RHEL7? |
|
I'll add the old one as well |
Gathering IO info from cadvisor for masters helps to understand and track performance issues. Add that accounting by default to all services.
smarterclayton
force-pushed
the
add_io_accounting
branch
from
b73f02f
to
5ddab4c
Compare
|
Evaluated for origin test up to 5ddab4c |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2265/) (Base Commit: c323526) |
|
Will systemd choke on flags it doesn't recognize?
…On Thu, Jun 15, 2017 at 12:06 PM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2265/)
(Base Commit: c323526
<c323526>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14644 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p5frZOzAqno-_4aNb2xwmtzL4ZGuks5sEVZ0gaJpZM4N6J7n>
.
|
|
It emits a warning message but does toggle the recognized flag. |
|
Ok, so then this should be gtg
…On Thu, Jun 15, 2017 at 10:19 PM, Scott Dodson ***@***.***> wrote:
It emits a warning message but does toggle the recognized flag.
Jun 15 22:15:29 ose3-master systemd[1]: [/etc/systemd/system.conf.d/origin-accounting.conf:4] Unknown lvalue 'DefaultIOAccounting' in section 'Manager'
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14644 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p535KbcEEWQSJ6g486cvRpCoyxviks5sEeZAgaJpZM4N6J7n>
.
|
sdodson
approved these changes
Jun 16, 2017
|
[merge][severity:bug]
|
|
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 3 |
|
Evaluated for origin merge up to 5ddab4c |
|
No conflicts with anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gathering IO info from cadvisor for masters helps to understand and
track performance issues. Add that accounting by default to all
services.
[test] @sdodson @sjennings @derekwaynecarr