UPSTREAM: 44115: scheduler should not log an error when no fit #14714
Conversation
|
[test] |
|
Evaluated for origin test up to 6ad7ba2 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2344/) (Base Commit: aeb4f30) (PR Branch Commit: 6ad7ba2) |
| if _, ok := err.(*core.FitError); ok { | ||
| glog.V(4).Infof("Unable to schedule %v %v: no fit: %v; waiting", pod.Namespace, pod.Name, err) | ||
| } else { | ||
| glog.Errorf("Error scheduling %v %v: %v; retrying", pod.Namespace, pod.Name, err) |
There was a problem hiding this comment.
My understanding is that to suppress "Error scheduling" too which is in the bug, it would require extending glog.V(4) to else part here. My previous PR addresses aggregation issue as expected in the bug.
|
lets take this as-is since its merged upstream, and see if the specific pod that @eparis has logging needs additional changes. [merge][severity:blocker] |
|
Evaluated for origin merge up to 6ad7ba2 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1050/) (Base Commit: f2be346) (PR Branch Commit: 6ad7ba2) (Extended Tests: blocker) (Image: devenv-rhel7_6381) |
xref kubernetes/kubernetes#44115
related https://bugzilla.redhat.com/show_bug.cgi?id=1462345