deploy: remove leading and trailing spaces from images #14744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tnozicka PTAL |
tnozicka
approved these changes
Jun 19, 2017
pkg/deploy/util/util.go
Outdated
| @@ -266,6 +266,13 @@ func MakeDeployment(config *deployapi.DeploymentConfig, codec runtime.Codec) (*a | |||
| return nil, fmt.Errorf("couldn't clone podSpec: %v", err) | |||
| } | |||
|
|
|||
| // Fix trailing and leading whitespace in the image field | |||
| // This is needed to sanitize old deployment configs where spaces were permitted but | |||
| // kuberneted 3.7 tightened the validation of container image fields. | |||
There was a problem hiding this comment.
s/kuberneted/kubernetes
maybe a ref to a PR making this change
mfojtik
force-pushed
the
ensure-no-whitespace
branch
from
41b9a83
to
cd7a677
Compare
|
[test] |
mfojtik
force-pushed
the
ensure-no-whitespace
branch
2 times, most recently
from
befbcd2
to
8968bde
Compare
mfojtik
force-pushed
the
ensure-no-whitespace
branch
from
8968bde
to
9cfb037
Compare
|
re-[test] |
|
Evaluated for origin test up to 9cfb037 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2422/) (Base Commit: e50d999) (PR Branch Commit: 9cfb037) |
|
[merge][severity:blocker] |
|
Evaluated for origin merge up to 9cfb037 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1077/) (Base Commit: 7461c10) (PR Branch Commit: 9cfb037) (Extended Tests: blocker) (Image: devenv-rhel7_6392) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14659