Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 47367: add client side event spam filtering #14747

Merged
merged 2 commits into from
Jul 1, 2017

Conversation

derekwaynecarr
Copy link
Member

xref kubernetes/kubernetes#47367

addresses event spam in large cluster sizes

@derekwaynecarr
Copy link
Member Author

marking wip while i update the godep for juju

@derekwaynecarr derekwaynecarr changed the title WIP: UPSTREAM: 47367: add client side event spam filtering UPSTREAM: 47367: add client side event spam filtering Jun 19, 2017
@derekwaynecarr
Copy link
Member Author

[test]

@derekwaynecarr
Copy link
Member Author

right now, this matches the upstream.

/cc @eparis @sjenning @smarterclayton

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2017
@eparis
Copy link
Member

eparis commented Jun 28, 2017

hack/build-go.sh  
++ Building go targets for linux/amd64: cmd/openshift cmd/oc cmd/kubefed pkg/sdn/plugin/sdn-cni-plugin vendor/github.com/containernetworking/cni/plugins/ipam/host-local vendor/github.com/containernetworking/cni/plugins/main/loopback
# github.com/openshift/origin/vendor/k8s.io/client-go/tools/record
vendor/k8s.io/client-go/tools/record/events_cache.go:457: syntax error: unexpected <<, expecting }
[ERROR] PID 142: hack/lib/build/binaries.sh:223: `GOOS=${platform%/*} GOARCH=${platform##*/} go install -pkgdir "${OS_OUTPUT_PKGDIR}/${platform}" -tags "${OS_GOFLAGS_TAGS-} ${!platform_gotags_envvar:-}" -ldflags="${local_ldflags}" "${goflags[@]:+${goflags[@]}}" "${nonstatics[@]}"` exited with status 2.

@derekwaynecarr
Copy link
Member Author

[test]

@derekwaynecarr
Copy link
Member Author

@eparis - sorry i had pushed something wrong, still getting back my muscle memory.

@derekwaynecarr derekwaynecarr removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2017
@derekwaynecarr
Copy link
Member Author

flaked on "oc new-app should succeed with a --name of 58 characters"

[test]

@derekwaynecarr
Copy link
Member Author

re [test]

@derekwaynecarr
Copy link
Member Author

flake on oc new-app re [test]

@derekwaynecarr
Copy link
Member Author

flake creating the cluster [test]

@derekwaynecarr
Copy link
Member Author

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 7f278e7

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2898/) (Base Commit: 983e367) (PR Branch Commit: 7f278e7)

@derekwaynecarr
Copy link
Member Author

success!

@eparis
Copy link
Member

eparis commented Jul 1, 2017

[merge]

@smarterclayton
Copy link
Contributor

smarterclayton commented Jul 1, 2017 via email

@eparis
Copy link
Member

eparis commented Jul 1, 2017

I'm going to tag with [merge] again The network test failed waiting for 3 dind nodes to be ready. There isn't much I'd say this PR was impossible to blame for...

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 7f278e7

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 1, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1200/) (Base Commit: 25b1950) (PR Branch Commit: 7f278e7) (Image: devenv-rhel7_6419)

@eparis
Copy link
Member

eparis commented Jul 1, 2017

of course the second time network looks just fine...

@openshift-bot openshift-bot merged commit 8836cb4 into openshift:master Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants