Allow templateinstance controller to instantiate non-v1 objects

[jim-minter]

fixes #14780

[jim-minter]

• implement test case

[jim-minter]

@deads2k @soltysh please can you take a look at this? It seems to solve the issue raised, but:

1. I've copied code from https://github.com/openshift/origin/blob/master/pkg/build/admission/jenkinsbootstrapper/admission.go#L107-L133 , which is in itself naughty
2. https://github.com/openshift/origin/blob/master/pkg/project/registry/projectrequest/delegated/delegated.go#L174 is also doing this wrong

I think a helper function like https://github.com/openshift/origin/blob/master/pkg/cmd/util/clientcmd/factory.go#L105 would be nice, but I don't know how to create all the clientcmd scaffolding in the contexts above (or better, how to avoid creating all the clientcmd scaffolding).

Please can you accept or suggest an acceptable achievable refactor?

@bparees

[soltysh]

I'm fine with this copy&paste for now. We'll probably want to address that in 3.7, properly. The only missing thing here is a test-case proving that different k8s resources can be easily created. @deads2k agreed?

[deads2k]

Why can't you move this to an openshift /resource package that returns a clientmapperfunc based on a config?

[deads2k]

Please can you accept or suggest an acceptable achievable refactor?

Suggestion made. I think that centralizing the problem and creating a clientmapperfunc from a config would be sufficient to move us forward.

[jim-minter]

updated.

[test][testextended][extended:core(templates)]

[bparees]

removed the merge tag, this appears to have panicked our extended tests:
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/691/testReport/junit/(root)/Extended/BeforeSuite/

haven't looked into it to confirm it is the culprit.

[jim-minter]

oops, too many threads in parallel - fixed and repushed

[bparees]

@@ -7319,7 +7319,7 @@ items:
         metadata:
           name: secret
       - kind: Deployment
-        apiVersion: extensions/v1beta1
+        apiVersion: apps/v1beta1
         metadata:
           name: deployment
         spec:
FAILURE: Generated test/extended bindata out of date. Please run hack/update-generated-bindata.sh

[jim-minter]

fixed and repushed

[openshift-bot]

Evaluated for origin testextended up to 2aabf5d

[openshift-bot]

Evaluated for origin test up to 2aabf5d

[openshift-bot]

continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/711/) (Base Commit: c3c286b) (PR Branch Commit: 2aabf5d) (Extended Tests: core(templates))

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2544/) (Base Commit: c3c286b) (PR Branch Commit: 2aabf5d)

[soltysh]

LGTM

[bparees]

[merge][severity:blocker]

[openshift-bot]

Evaluated for origin merge up to 2aabf5d

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1115/) (Base Commit: 9b2743f) (PR Branch Commit: 2aabf5d) (Extended Tests: blocker) (Image: devenv-rhel7_6396)