Add oadm migrate volumesource #14810
Conversation
enj
force-pushed
the
enj/i/volume_source_metadata/14677
branch
from
81e44dc
to
ac241da
Compare
|
re[test] flake #14823 |
pkg/cmd/admin/migrate/migrator.go
Outdated
| @@ -49,6 +49,8 @@ func AlwaysRequiresMigration(_ *resource.Info) (Reporter, error) { | |||
| return ReporterBool(true), nil | |||
| } | |||
|
|
|||
| var NotChanged = ReporterBool(false) | |||
| * jobs | ||
| * podpresets | ||
| * pods | ||
| * podsecuritypolicyreviews |
There was a problem hiding this comment.
not persisted, so it doesn't need to be checked.
| * podpresets | ||
| * pods | ||
| * podsecuritypolicyreviews | ||
| * podsecuritypolicyselfsubjectreviews |
There was a problem hiding this comment.
not persisted, so it doesn't need to be checked.
| * pods | ||
| * podsecuritypolicyreviews | ||
| * podsecuritypolicyselfsubjectreviews | ||
| * podsecuritypolicysubjectreviews |
There was a problem hiding this comment.
not persisted, so it doesn't need to be checked.
| * podsecuritypolicyselfsubjectreviews | ||
| * podsecuritypolicysubjectreviews | ||
| * podtemplates | ||
| * replicasets |
There was a problem hiding this comment.
list groups too. replicasets.extensions
| Out: out, | ||
| ErrOut: errout, | ||
| AllNamespaces: true, | ||
| Include: []string{ |
There was a problem hiding this comment.
Why is this thing a string and not a GroupResource?
|
Minor comments, lgtm otherwise. Open a pull that deletes this too and we'll merge it after we branch 3.6. |
Signed-off-by: Monis Khan <mkhan@redhat.com>
This command confirms that all objects that contain volumeSource.metadata do not have it set. volumeSource.metadata is deprecated and will no longer be available in the next release. Thus all objects that contain a non-nil volumeSource.metadata must be manually converted to prevent data loss. The following resource types are checked by this command: * cronjobs.batch * daemonsets.extensions * deploymentconfigs.apps.openshift.io * deployments.extensions * jobs.batch * podpresets.settings.k8s.io * pods * podtemplates * replicasets.extensions * replicationcontrollers * statefulsets.apps No resources are mutated. Signed-off-by: Monis Khan <mkhan@redhat.com>
Signed-off-by: Monis Khan <mkhan@redhat.com>
enj
force-pushed
the
enj/i/volume_source_metadata/14677
branch
from
ac241da
to
44025d9
Compare
|
Evaluated for origin test up to 44025d9 |
|
[merge][severity:blocker] all comments addressed. @deads2k can you do a sanity check on the |
|
Opened #14873 for 3.7 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2579/) (Base Commit: 9b2743f) (PR Branch Commit: 44025d9) |
|
Evaluated for origin merge up to 44025d9 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1132/) (Base Commit: 1fb3ade) (PR Branch Commit: 44025d9) (Extended Tests: blocker) (Image: devenv-rhel7_6396) |
oadm migrate volumesourceconfirms that all objects that containvolumeSource.metadatado not have it set.volumeSource.metadatais deprecated and will no longer be available in the next release. Thus all objects that contain a non-nilvolumeSource.metadatamust be manually converted to prevent data loss.The following resource types are checked by this command:
No resources are mutated.
Signed-off-by: Monis Khan mkhan@redhat.com
Fixes #14677
cc @deads2k @smarterclayton @liggitt @simo5 @sdodson @openshift/security
[test]