-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy: honor BindAddress for the iptables proxy #14815
proxy: honor BindAddress for the iptables proxy #14815
Conversation
A loose port of kubernetes/kubernetes#46678 If the configuration specifies a BindAddress, we should probably honor it. If the configuration doesn't, and there is no default route with which to autodetect the node address, then the user really needs to tell the proxy what address to use via BindAddress. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1462428
369c486
to
c9b91fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[test][testextended][extended: networking] |
[merge][severity: blocker] |
Evaluated for origin testextended up to c9b91fa |
Evaluated for origin merge up to c9b91fa |
Evaluated for origin test up to c9b91fa |
continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/687/) (Base Commit: 7657e99) (PR Branch Commit: c9b91fa) (Extended Tests: networking) |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2509/) (Base Commit: 7657e99) (PR Branch Commit: c9b91fa) |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1087/) (Base Commit: 651dd88) (PR Branch Commit: c9b91fa) (Extended Tests: blocker) (Image: devenv-rhel7_6392) |
Will this break existing users? |
A loose port of kubernetes/kubernetes#46678
If the configuration specifies a BindAddress, we should probably
honor it. If the configuration doesn't, and there is no default
route with which to autodetect the node address, then the user
really needs to tell the proxy what address to use via BindAddress.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1462428
@openshift/networking @knobunc