Preserve backwards compatibilty for old routes for destination CA #14818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarterclayton
force-pushed
the
backcompat_for_routes
branch
2 times, most recently
from
68b5755
to
fcf3923
Compare
|
Tests added, ran against a 1.5.1 router and got: because we inject the "fake" destinationCACertificate that is not parseable. |
|
And of course our error output is atrocious, but at least it's correct: |
|
[severity:blocker] |
|
@liggitt for API compatibility |
smarterclayton
force-pushed
the
backcompat_for_routes
branch
from
fcf3923
to
9df28d4
Compare
knobunc
approved these changes
Jun 22, 2017
|
[test][testextended][extended: networking] The last test flaked on #13271 |
|
I still have to fix something in the client commit, will do so in a bit.
On Jun 22, 2017, at 6:31 AM, OpenShift Bot <notifications@github.com> wrote:
continuous-integration/openshift-jenkins/testextended Running (
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/686/)
(Base Commit: 0fba3e5
<0fba3e5>)
(PR Branch Commit: 9df28d4
<9df28d4>)
(Extended Tests: networking)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14818 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p2UdAjkc8uSVdX-4vlPauiKF_qDiks5sGlCbgaJpZM4OBmJK>
.
|
smarterclayton
force-pushed
the
backcompat_for_routes
branch
2 times, most recently
from
730b56e
to
4da9a14
Compare
deads2k
reviewed
Jun 23, 2017
| case "routes": | ||
| restStorage := s.(*routeetcd.REST) | ||
| store := *restStorage.Store | ||
| store.Decorator = routeregistry.DecorateLegacyRouteWithEmptyDestinationCACertificates |
There was a problem hiding this comment.
@liggitt I haven't used the decorator before. Does it play nicely the various storage caches involved?
There was a problem hiding this comment.
things are copied before they come out of the cache, because of self link (which is always set)
There was a problem hiding this comment.
but it's good to double check. We've used Decorators for the last 3 years with ImageStreams, so not terribly worried.
smarterclayton
force-pushed
the
backcompat_for_routes
branch
from
4da9a14
to
a8ddb9a
Compare
openshift-bot
added
the
needs-rebase
|
@openshift/networking FYI |
smarterclayton
force-pushed
the
backcompat_for_routes
branch
from
a8ddb9a
to
0476a14
Compare
openshift-bot
removed
the
needs-rebase
|
[test]
…On Mon, Jun 26, 2017 at 8:07 PM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2647/)
(Base Commit: d007fa3
<d007fa3>)
(PR Branch Commit: 0476a14
<0476a14>
)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14818 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pyJHKu3B8KiNqa9WFpwTq_hwrDOsks5sIEfKgaJpZM4OBmJK>
.
|
OpenShift 3.6 allows destinationCACertificates on the new route.openshift.io group for reencrypt routes to be empty. To preserve backwards compatibility for the existing route API, set a simple "no-op" PEM into the returned REST response, and strip it if a client round trips it. A v1 client that tries to send an empty destinationCACertificate will be allowed to do so, but will get back a response that includes the empty PEM file.
smarterclayton
force-pushed
the
backcompat_for_routes
branch
from
0476a14
to
a3c81a1
Compare
|
Evaluated for origin testextended up to a3c81a1 |
|
continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/753/) (Base Commit: 3704f7f) (PR Branch Commit: a3c81a1) (Extended Tests: networking) |
|
LGTM |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 7 |
|
Evaluated for origin merge up to a3c81a1 |
|
[test] |
|
Evaluated for origin test up to a3c81a1 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2716/) (Base Commit: cf83ff4) (PR Branch Commit: a3c81a1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenShift 3.6 allows destinationCACertificates on the new
route.openshift.io group for reencrypt routes to be empty. To preserve
backwards compatibility for the existing route API, set a simple "no-op"
PEM into the returned REST response, and strip it if a client round trips
it. A v1 client that tries to send an empty destinationCACertificate will
be allowed to do so, but will get back a response that includes the empty
PEM file.
I still need to add a set of tests
[test] @knobunc