Add a diagnostic that runs extended validation on routes #14819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Miciah this will flag routes that fail extended validation, and we would invoke prior to upgrade for non-online clusters |
|
@openshift/networking FYI |
|
[merge][severity:blocker] (planning on making ansible block this on upgrade) |
|
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 12 |
|
Evaluated for origin merge up to 39eee51 |
|
re[test] |
In 3.6 route extended validation has become more aggressive. This
diagnostic makes it easy for an admin to test how many routes on the
cluster would fail extended validation by running it on all routes.
$ oadm diagnostics RouteCertificateValidation
will report all failing routes.
smarterclayton
force-pushed
the
validate_route
branch
from
39eee51
to
bd79ab1
Compare
|
[test]
…On Mon, Jun 26, 2017 at 8:07 PM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2649/)
(Base Commit: a5bf960
<a5bf960>)
(PR Branch Commit: bd79ab1
<bd79ab1>
)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14819 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pz8p_fOQBu-mL_J5UxCrca1ho56vks5sIEfKgaJpZM4OBvK->
.
|
|
Evaluated for origin test up to bd79ab1 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2665/) (Base Commit: 955efb1) (PR Branch Commit: bd79ab1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3.6 route extended validation has become more aggressive. This
diagnostic makes it easy for an admin to test how many routes on the
cluster would fail extended validation by running it on all routes.
will report all failing routes.
[test] @knobunc @liggitt