move API types to consistent packages

[deads2k]

@openshift/api-review as we discussed, this moves our API types to make them consistent with all other api types in existence. This has to merge for 3.6 or we will be unable to pick changes back.

[test] to see what was missed.

[deads2k]

Hey, only 20k lines. That's better than I thought it would be.

[stevekuznetsov]

Are you expecting this to stick around?

[deads2k]

Are you expecting this to stick around?

Not in the sense of "this script needs to be pretty". I want the script in this pull so that people can see if it does roughly what they expect instead of reviewing the 20k diff.

[deads2k]

Try running 'gofmt -s -d [path]'
Or autocorrect with 'hack/verify-gofmt.sh | xargs -n 1 gofmt -s -w'
pkg/dockerregistry/testutil/fakeopenshift.go:16: imageapi redeclared as imported package name
	previous declaration at pkg/dockerregistry/testutil/fakeopenshift.go:15

and clientset verifier
regenerate protobuf again.  Something is off

[deads2k]

I'd like this after #14701

[deads2k]

re[test]

[deads2k]

failed to provision re[test] green except for gce, yay!

[openshift-bot]

Evaluated for origin test up to af2e30d

[deads2k]

[testextended][extended:core(builds)]

[deads2k]

@liggitt builds on the SCC pull. Can you take a look. This actually has a shot at being green and being on a valid base for a force.

[openshift-bot]

Evaluated for origin testextended up to af2e30d

[openshift-bot]

continuous-integration/openshift-jenkins/testextended Running (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/740/) (Base Commit: 07cba93) (PR Branch Commit: af2e30d) (Extended Tests: core(builds))

[liggitt]

the changes to this package surprised me

[deads2k]

the changes to this package surprised me

weird, but it looks like it will hold (symlink to file with same content) and be fixable immediately after.

[liggitt]

that's fine

[liggitt]

LGTM

[liggitt]

looks good to merge on green tests against master HEAD

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2618/) (Base Commit: 07cba93) (PR Branch Commit: af2e30d)

[deads2k]

Base commit is the current HEAD of master (minus webconsole commits), tests are green, currently merging pull flaked, it won't get better than this. Merging and aborting the current job.