Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure that GC can delete privileged pods #14867

Merged
merged 2 commits into from
Jun 25, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jun 23, 2017

We had two problems:

  1. equality failed when using some protobuf and some json clients
  2. orphaning requires finalizer updates.

@jwforres

@deads2k
Copy link
Contributor Author

deads2k commented Jun 23, 2017

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to b66e3b4

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2564/) (Base Commit: 75c6d6e) (PR Branch Commit: b66e3b4)

@liggitt
Copy link
Contributor

liggitt commented Jun 24, 2017

LGTM [merge][severity:blocker]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to b66e3b4

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 25, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1123/) (Base Commit: e0c7707) (PR Branch Commit: b66e3b4) (Extended Tests: blocker) (Image: devenv-rhel7_6396)

@openshift-bot openshift-bot merged commit ce0c17d into openshift:master Jun 25, 2017
@deads2k deads2k deleted the gc-03-equality branch August 3, 2017 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants