UPSTREAM: 47347: actually check for a live discovery endpoint before …

[deads2k]

…aggregating (part 2)

Fixes #14842

It seems that using a timeout on a request doesn't make the request call return (weird), but it does kick the context.Done() and give a valid error message back. https://godoc.org/golang.org/x/net/context#Context

[test]

[mfojtik]

LGTM

[openshift-bot]

Evaluated for origin merge up to f7a3fed

[deads2k]

too much has merged for a manual merge.

re[test]

[deads2k]

re[test]

[openshift-bot]

continuous-integration/openshift-jenkins/merge Running (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1164/) (Base Commit: 1a96817) (PR Branch Commit: f7a3fed)

[smarterclayton]

Hrm, this looks like it's failing on GCE

[deads2k]

Hrm, this looks like it's failing on GCE

My kingdom for a log. How can I see the master logs?

[smarterclayton]

will try to recreate and get them for you

[smarterclayton]

etwork default (network: "172.16.0.0/16", hostSubnetBits: 9, serviceNetwork: "172.30.0.0/16", pluginName: "redhat/openshift-ovs-subnet")
ge Collector: All resource monitors have synced. Proceeding to collect garbage
oleBinding): 1 objects queued in incoming channel.
lusterRoleBinding): 1 objects queued in incoming channel.
lusterRole): 1 objects queued in incoming channel.
lusterRoleBinding): 2 objects queued in incoming channel.
penshift/origin/pkg/sdn/plugin/common.go:181: Failed to watch *network.HostSubnet: unknown (get hostsubnets)
lusterRole): 2 objects queued in incoming channel.
penshift/origin/pkg/sdn/plugin/common.go:181: Failed to watch *network.HostSubnet: unknown (get hostsubnets)
penshift/origin/pkg/sdn/plugin/common.go:181: Failed to watch *network.HostSubnet: unknown (get hostsubnets)
penshift/origin/pkg/sdn/plugin/common.go:181: Failed to watch *network.HostSubnet: unknown (get hostsubnets)
penshift/origin/pkg/sdn/plugin/common.go:181: Failed to watch *network.HostSubnet: unknown (get hostsubnets)
penshift/origin/pkg/sdn/plugin/common.go:181: Failed to watch *network.HostSubnet: unknown (get hostsubnets)
penshift/origin/pkg/sdn/plugin/common.go:181: Failed to watch *network.HostSubnet: unknown (get hostsubnets)
penshift/origin/pkg/sdn/plugin/common.go:181: Failed to watch *network.HostSubnet: unknown (get hostsubnets)

[smarterclayton]

Haven't seen those errors on any other PR

[smarterclayton]

That's from the same RPMs you used against ansible master - the only failure i can see. Was consistent after restart. Not happening in origin master.

[deads2k]

That's from the same RPMs you used against ansible master - the only failure i can see. Was consistent after restart. Not happening in origin master.

Thanks.

[smarterclayton]

I can spin a cluster up if you need one today On Jun 29, 2017, at 7:59 AM, David Eads <notifications@github.com> wrote: That's from the same RPMs you used against ansible master - the only failure i can see. Was consistent after restart. Not happening in origin master. Thanks. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#14881 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_pxRs8dJaIj7KxdHQ8VVbtI76haSRks5sI5GygaJpZM4OFNoZ> .

[deads2k]

That looks shockingly similar to https://bugzilla.redhat.com/show_bug.cgi?id=1465361 . I wonder why I can't get that locally.

[deads2k]

re[test]. I really can't see how this change (to non-local apiservices) can cause a failure in a local APIservice.

[smarterclayton]

Flake #14881

[smarterclayton]

[test]

[smarterclayton]

Yeah, I'm not sure this is your problem, the linked bug definitely is happening regardless. If I get another green I'll merge.

[deads2k]

hit the new-app problem this time. https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2828/

re[test]

[smarterclayton]

[test]

…

On Fri, Jun 30, 2017 at 9:47 AM, OpenShift Bot ***@***.***> wrote: continuous-integration/openshift-jenkins/test FAILURE ( https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2861/) (Base Commit: 383de81 <383de81>) (PR Branch Commit: f7a3fed <f7a3fed> ) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#14881 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p_88Pxbtt0jlE_7sFy9YOKec-cE_ks5sJPx1gaJpZM4OFNoZ> .

[openshift-bot]

Evaluated for origin test up to f7a3fed

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2868/) (Base Commit: 025772c) (PR Branch Commit: f7a3fed)