Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow templateinstance updates for GC #14918

Merged
merged 1 commit into from
Jun 27, 2017
Merged

allow templateinstance updates for GC #14918

merged 1 commit into from
Jun 27, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jun 27, 2017

Fixes #14809 (I think)

[test]

@deads2k
Copy link
Contributor Author

deads2k commented Jun 27, 2017

GC attempts to do a patch of finalizers and/or ownerrefs on objects as part of deletion. We need to make sure that its always allowed to do that.

@jim-minter
Copy link
Contributor

lgtm; thanks for that

@jim-minter jim-minter assigned deads2k and unassigned jim-minter Jun 27, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Jun 27, 2017

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 27, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 11

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to f8e6fe1

@smarterclayton
Copy link
Contributor

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to f8e6fe1

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2721/) (Base Commit: cf83ff4) (PR Branch Commit: f8e6fe1)

@smarterclayton smarterclayton merged commit a67ac87 into openshift:master Jun 27, 2017
@liggitt
Copy link
Contributor

liggitt commented Jun 27, 2017

This seems like it will happen often enough that we should have an integration test that creates one of every object, attempts to delete it with foreground deletion policy, and ensures the garbage collector can patch it and clean it up

@deads2k deads2k deleted the gc-04-allow-gc-mutation branch August 3, 2017 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@deads2k deads2k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deads2k @jim-minter @openshift-bot @smarterclayton @liggitt