Disable ThirdPartyController #14969
Merged
Disable ThirdPartyController #14969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enj
force-pushed
the
enj/i/disable_third_party_controller/14739,14878
branch
from
c4e591d
to
300961c
Compare
|
Flake #14897, tests are good otherwise. @deads2k @smarterclayton PTAL. |
|
@enj there should be a list of disabled poststarthooks. Please use that instead. |
deads2k
reviewed
Jun 30, 2017
| @@ -84,7 +84,7 @@ var expectedIndex = []string{ | |||
| "/healthz/ping", | |||
| "/healthz/poststarthook/bootstrap-controller", | |||
| "/healthz/poststarthook/ca-registration", | |||
| "/healthz/poststarthook/extensions/third-party-resources", | |||
| // "/healthz/poststarthook/extensions/third-party-resources", // Do not enable this controller, it breaks go-restful | |||
enj
force-pushed
the
enj/i/disable_third_party_controller/14739,14878
branch
from
300961c
to
7dbfc7f
Compare
|
squash and lgtm. |
This change makes it so that the third party resource controller does not run. This controller breaks the API's go-restful containers by removing handlers. The remove functionality is broken, and destroys the server mux when it is called. Signed-off-by: Monis Khan <mkhan@redhat.com>
enj
force-pushed
the
enj/i/disable_third_party_controller/14739,14878
branch
from
7dbfc7f
to
acd03a7
Compare
|
[merge] comments addressed. |
|
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 11 |
|
Evaluated for origin merge up to acd03a7 |
|
Evaluated for origin test up to acd03a7 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2877/) (Base Commit: 916ac6c) (PR Branch Commit: acd03a7) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that the third party resource controller does not run. This controller breaks the API's go-restful containers by removing handlers. The remove functionality is broken, and destroys the server mux when it is called.
Supersedes #14739
Fixes #14878
xref emicklei/go-restful/issues/344
@openshift/security
[test]