Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployer controller emits event when failed to create deploy pod #14970

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

derekwaynecarr
Copy link
Member

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1465801

changes

  1. emit an event if you cannot create a deployer pod right away to improve ux
  2. cleanup the event text when doing failed retry to remove the deployment.name because events are already about that deployment inherently.

@derekwaynecarr
Copy link
Member Author

/cc @eparis @smarterclayton

@0xmichalis
Copy link
Contributor

lgtm [merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2017

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 12

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 7c940ee

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 7c940ee

@derekwaynecarr
Copy link
Member Author

[merge][severity:blocker]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2844/) (Base Commit: dc5a05f) (PR Branch Commit: 7c940ee)

@eparis eparis merged commit a2dc408 into openshift:master Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants