Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster up: Fix the regular expression used to parse openshift version #15055

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Jul 5, 2017

Factors out the code in a function and adds a unit test to test it.
Fixes #15039

@csrwng
Copy link
Contributor Author

csrwng commented Jul 5, 2017

@bparees ptal

@bparees
Copy link
Contributor

bparees commented Jul 5, 2017

lgtm [merge][severity:blocker]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 7dc2264

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@bparees
Copy link
Contributor

bparees commented Jul 5, 2017

flake #15068
[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 7dc2264

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 6, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1238/) (Base Commit: 071f2c1) (PR Branch Commit: 7dc2264) (Extended Tests: blocker) (Image: devenv-rhel7_6427)

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2985/) (Base Commit: 72b9f3d) (PR Branch Commit: 7dc2264)

@openshift-bot openshift-bot merged commit 073332f into openshift:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants