run must output message on container error #15090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
fabianofranz
force-pushed
the
issues_15031
branch
from
56ecd18
to
1bcfd87
Compare
|
Ugly, but can live with that. /lgtm |
|
[merge][severity: blocker] |
|
re[test] |
fabianofranz
force-pushed
the
issues_15031
branch
from
1bcfd87
to
a8c06d5
Compare
|
Evaluated for origin test up to a8c06d5 |
|
Evaluated for origin merge up to a8c06d5 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3019/) (Base Commit: 349768c) (PR Branch Commit: a8c06d5) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1254/) (Base Commit: 2d61a5b) (PR Branch Commit: a8c06d5) (Extended Tests: blocker) (Image: devenv-rhel7_6432) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15031
Picks kubernetes/kubernetes#48578
oc runmust output a message (instead of just exiting with an error code) on container error.