Perform live OAuth client check only if scopes were added to the client authorization #15149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enj
force-pushed
the
enj/i/migrate_storage_oauthclientauthorizations/15007
branch
from
9391de9
to
92b6707
Compare
This change makes it so that OAuthClientAuthorization update validation only does a live OAuth client check to validate scopes if new scopes were added to the client authorization. If the scopes were unchanged or only removed (removal of all scopes is considered an addition since an empty slice means all scopes), than no live lookup is performed under the assumption that the create method did a successful live lookup at some earlier point. This makes it so that an update to a client authorization with identical data (for example, during storage migration) will not fail if the referenced client is no longer valid or has been deleted. Signed-off-by: Monis Khan <mkhan@redhat.com>
enj
force-pushed
the
enj/i/migrate_storage_oauthclientauthorizations/15007
branch
from
92b6707
to
bb13f12
Compare
|
[severity:blocker] |
|
xref #14999 |
|
LGTM |
|
LGTM. |
|
👍 |
|
[test] |
|
Evaluated for origin test up to bb13f12 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3061/) (Base Commit: edb53ef) (PR Branch Commit: bb13f12) |
php-coder
reviewed
Jul 13, 2017
|
|
||
| newScopes := sets.NewString(obj...) | ||
| oldScopes := sets.NewString(old...) | ||
| return len(newScopes.Difference(oldScopes)) > 0 |
There was a problem hiding this comment.
(I'm not sure but) why not use !oldScopes.IsSuperset(newScopes) instead? It won't collect the items that we don't need anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that
OAuthClientAuthorizationupdate validation only does a live OAuth client check to validate scopes if new scopes were added to the client authorization. If the scopes were unchanged or only removed (removal of all scopes is considered an addition since an empty slice means all scopes), than no live lookup is performed under the assumption that the create method did a successful live lookup at some earlier point. This makes it so that an update to a client authorization with identical data (for example, during storage migration) will not fail if the referenced client is no longer valid or has been deleted.Signed-off-by: Monis Khan mkhan@redhat.com
Fixes #15007
xref: #15007 (comment)
[test]
@jupierce @openshift/security
@liggitt PTAL