Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the advanced audit backend #15657

Merged
merged 1 commit into from
Aug 13, 2017

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Aug 7, 2017

Fixes #15271.

@deads2k || @sttts for wiring
@smarterclayton for api change

There are a few changes when turning on the new audit:

  1. one line instead of two (previously we've logged the response on separate line), see old and new:
AUDIT: id="ac14f7c8-1891-4551-9da4-e5075e9d89c6" stage="ResponseComplete" ip="127.0.0.1" method="list" user="test-admin" groups="\"system:authenticated:oauth\",\"system:authenticated\"" as="<self>" asgroups="<lookup>" namespace="test" uri="/api/v1/namespaces/test/pods" response="200"
  1. the method changed from HTTP action to actual operation performed
  2. there's a new field stage showing when the event was generated

I'll open a separate PR enabling other alpha features after I sync with @mpbarrett

@openshift-merge-robot openshift-merge-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 7, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: soltysh
We suggest the following additional approver: deads2k

Assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@sttts
Copy link
Contributor

sttts commented Aug 7, 2017

Can we backport the json file output as well? I would rather set json as default than introducing another incompatible unstructured format.

@sttts
Copy link
Contributor

sttts commented Aug 7, 2017

Here it is: kubernetes/kubernetes#48605

@soltysh
Copy link
Contributor Author

soltysh commented Aug 7, 2017

Can we backport the json file output as well? I would rather set json as default than introducing another incompatible unstructured format.

That's reasonable. I'd like to enable the new audit first and then in a separate PR I'll work on the addons which we want to enable.

@soltysh
Copy link
Contributor Author

soltysh commented Aug 11, 2017

/retest

@soltysh
Copy link
Contributor Author

soltysh commented Aug 11, 2017

I got a verbal approval of this change from @smarterclayton and @pweil- I'm applying the necessary labels manually to push this forward.

@soltysh soltysh added api-approved approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. and removed needs-api-review labels Aug 11, 2017
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

@soltysh: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce d0bbf8e link /test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install_update d0bbf8e link /test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 15657, 15748)

@openshift-merge-robot openshift-merge-robot merged commit 200364e into openshift:master Aug 13, 2017
@soltysh soltysh deleted the advanced_audit branch August 14, 2017 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-approved approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants