-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to the advanced audit backend #15657
Switch to the advanced audit backend #15657
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: soltysh Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Can we backport the json file output as well? I would rather set json as default than introducing another incompatible unstructured format. |
Here it is: kubernetes/kubernetes#48605 |
That's reasonable. I'd like to enable the new audit first and then in a separate PR I'll work on the addons which we want to enable. |
/retest |
I got a verbal approval of this change from @smarterclayton and @pweil- I'm applying the necessary labels manually to push this forward. |
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest Please review the full test history for this PR and help us cut down flakes. |
/test all [submit-queue is verifying that this PR is safe to merge] |
@soltysh: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue (batch tested with PRs 15657, 15748) |
Fixes #15271.
@deads2k || @sttts for wiring
@smarterclayton for api change
There are a few changes when turning on the new audit:
stage
showing when the event was generatedI'll open a separate PR enabling other alpha features after I sync with @mpbarrett