Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 51705: Address panic in TestCancelAndReadd #16077

Conversation

enj
Copy link
Contributor

@enj enj commented Aug 31, 2017

This further increases the timeouts in timed_workers_test to reduce the chance of a race condition against the wait group.

Signed-off-by: Monis Khan mkhan@redhat.com

This further increases the timeouts in timed_workers_test to reduce
the chance of a race condition against the wait group.

Signed-off-by: Monis Khan <mkhan@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 31, 2017
@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, smarterclayton

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16074, 16069, 16077, 16079, 16014)

openshift-merge-robot added a commit that referenced this pull request Sep 1, 2017
Automatic merge from submit-queue (batch tested with PRs 16074, 16069, 16077, 16079, 16014)

UPSTREAM: 51705: Address panic in TestCancelAndReadd

This further increases the timeouts in timed_workers_test to reduce the chance of a race condition against the wait group.

Signed-off-by: Monis Khan <mkhan@redhat.com>
@openshift-merge-robot openshift-merge-robot merged commit a546bc2 into openshift:master Sep 1, 2017
openshift-merge-robot added a commit that referenced this pull request Sep 20, 2017
Automatic merge from submit-queue

UPSTREAM: <carry>: increase timeout in TestCancelAndReadd even more

Fixes #16404.

Apparently #16077 didn't fix the problem. #16404 is showing that we're hitting this more and more.

@mfojtik @Kargakis @enj ptal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants