-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 53233: Remove containers from deleted pods once containers have exited #16914
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: joelsmith Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/kind bug |
strongly prefer #16913 |
closing in favor of #16913 |
@joelsmith: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
UPSTREAM: 53233: Remove containers from deleted pods once containers have exited
which needed
UPSTREAM: 47316: Added golint check for pkg/kubelet.
to cleanly apply.
Note to reviewer: This is definitely one that is easier to review as separate commits
xref kubernetes/kubernetes#53233
xref kubernetes/kubernetes#47316
NOTE: There is an alternate version of this PR without the golint commit:
#16913
we need to decide which is the better version.