Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't run conformance tests w/ serial unless they are part of the focus #16919

Merged
merged 1 commit into from
Oct 19, 2017

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Oct 17, 2017

fixes #16626

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2017
@bparees
Copy link
Contributor Author

bparees commented Oct 17, 2017

/test extended_builds
/test extended_image_ecosystem

@bparees
Copy link
Contributor Author

bparees commented Oct 17, 2017

@smarterclayton @stevekuznetsov @miminar @jim-minter I firmly believe this is the right solution to our current e2e serial testing w/ focus problem. I know the long term vision is a separate serial suite (and ultimately no serial tests at all) but for now this gets the behavior closer to correct at a minimal cost, with minimal complexity, while preserving the ability to run focused tests on serial items.

@smarterclayton
Copy link
Contributor

smarterclayton commented Oct 17, 2017 via email

@bparees
Copy link
Contributor Author

bparees commented Oct 18, 2017

/retest

@bparees bparees added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2017
@bparees
Copy link
Contributor Author

bparees commented Oct 18, 2017

Stop using serial.

getting rid of the build test one here:
#16924

registry ones are going to be a harder slog.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jim-minter
Copy link
Contributor

does this close #16626?
is it worth opening a tracking issue for migrating registry tests of serial?

@openshift-ci-robot
Copy link

@bparees: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_builds 37dd59f link /test extended_builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bparees
Copy link
Contributor Author

bparees commented Oct 19, 2017

does this close #16626?

yes, updated the description.

is it worth opening a tracking issue for migrating registry tests of serial?

yes, opened #16942

@bparees bparees added kind/bug Categorizes issue or PR as related to a bug. retest-not-required labels Oct 19, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 64bad7b into openshift:master Oct 19, 2017
@bparees bparees deleted the serial branch October 20, 2017 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. retest-not-required size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conformance tests run in serial suite when focus is set
8 participants