-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apps: extend extended tests to better check for deployer invariants and enable back the old check #16998
apps: extend extended tests to better check for deployer invariants and enable back the old check #16998
Conversation
39957d6
to
7324453
Compare
this is currently blocked on #17011 |
7324453
to
e8cad12
Compare
@mfojtik this is now ready for your review |
@@ -121,20 +121,21 @@ func (c *DeploymentConfigController) Handle(config *deployapi.DeploymentConfig) | |||
return c.updateStatus(config, existingDeployments) | |||
} | |||
|
|||
latestIsDeployed, latestDeployment := deployutil.LatestDeploymentInfo(config, existingDeployments) | |||
latestExists, latestDeployment := deployutil.LatestDeploymentInfo(config, existingDeployments) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is more "latestControllerCreated" :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I made it to be consistent with some other occurrences in our code
yes, (latestRCCreated || latestRCRunning || latestRCDeployed) - I guess exists covers it but I don't really have a preference except we stop calling it latestDeployed which I find confusing because it implies it is in terminal state
/retest |
#17042 is in. Tests have a chance on passing now :) |
e8cad12
to
6a1e162
Compare
rebased |
/retest |
1 similar comment
/retest |
@mfojtik tests are green /test all |
/hold cancel |
@mfojtik I think we should merge it if you are fine with it. This should be part of 3.7. |
@mfojtik are we still targeting 3.7(.1?) with this? |
28b75c0
to
ba495e5
Compare
@mfojtik rebased and ready for your review |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, tnozicka The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue (batch tested with PRs 17350, 16998). |
…e-to-cancellation Automatic merge from submit-queue (batch tested with PRs 17350, 16998). apps: extend extended tests to better check for deployer invariants and enable back the old check enabling back #16956
@tnozicka: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
enabling back #16956