Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit-tests: fixed flake and race in image pruning #17105

Merged
merged 1 commit into from
Oct 31, 2017

Conversation

miminar
Copy link

@miminar miminar commented Oct 31, 2017

Resolves: #16821 (comment)

Signed-off-by: Michal Minář <miminar@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2017
@miminar
Copy link
Author

miminar commented Oct 31, 2017

Resolves #16821 (comment)

/assign @bparees

@miminar miminar changed the title extended: annotated registry tests unit-tests: fixed flake and race in image pruning Oct 31, 2017
@bparees bparees added the kind/bug Categorizes issue or PR as related to a bug. label Oct 31, 2017
@bparees
Copy link
Contributor

bparees commented Oct 31, 2017

/unassign @juanvallejo @fabianofranz
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, miminar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2017
@eparis
Copy link
Member

eparis commented Oct 31, 2017

/retest

@eparis
Copy link
Member

eparis commented Oct 31, 2017

This flake has been so bad getting things into the queue (>50% failure rate) that I'm going to break all the rules and merge by hand (it is green)

@eparis eparis merged commit 5f680fe into openshift:master Oct 31, 2017
@miminar miminar deleted the image-pruning-flake-fix branch November 8, 2017 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. queue/critical-fix size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants