Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plumb through the clusterresourceoverride settings #18076

Merged
merged 1 commit into from
Jan 15, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 22 additions & 18 deletions pkg/assets/apiserver/asset_apiserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import (
"github.com/openshift/origin/pkg/cmd/server/crypto"
cmdutil "github.com/openshift/origin/pkg/cmd/util"
oauthutil "github.com/openshift/origin/pkg/oauth/util"
overrideapi "github.com/openshift/origin/pkg/quota/admission/clusterresourceoverride/api"
"github.com/openshift/origin/pkg/util/httprequest"
oversion "github.com/openshift/origin/pkg/version"
)
Expand All @@ -43,7 +44,8 @@ const (
type AssetServerConfig struct {
GenericConfig *genericapiserver.Config

Options oapi.AssetConfig
Options oapi.AssetConfig
LimitRequestOverrides *overrideapi.ClusterResourceOverrideConfig

PublicURL url.URL
}
Expand All @@ -59,7 +61,7 @@ type completedAssetServerConfig struct {
*AssetServerConfig
}

func NewAssetServerConfig(assetConfig oapi.AssetConfig) (*AssetServerConfig, error) {
func NewAssetServerConfig(assetConfig oapi.AssetConfig, limitRequestOverrides *overrideapi.ClusterResourceOverrideConfig) (*AssetServerConfig, error) {
publicURL, err := url.Parse(assetConfig.PublicURL)
if err != nil {
glog.Fatal(err)
Expand Down Expand Up @@ -97,9 +99,10 @@ func NewAssetServerConfig(assetConfig oapi.AssetConfig) (*AssetServerConfig, err
genericConfig.SecureServingInfo.CipherSuites = crypto.CipherSuitesOrDie(assetConfig.ServingInfo.CipherSuites)

return &AssetServerConfig{
GenericConfig: genericConfig,
Options: assetConfig,
PublicURL: *publicURL,
GenericConfig: genericConfig,
Options: assetConfig,
LimitRequestOverrides: limitRequestOverrides,
PublicURL: *publicURL,
}, nil
}

Expand Down Expand Up @@ -216,19 +219,20 @@ func (c *completedAssetServerConfig) addWebConsoleConfig(serverMux *genericmux.P

// Generated web console config and server version
config := assets.WebConsoleConfig{
APIGroupAddr: masterURL.Host,
APIGroupPrefix: server.APIGroupPrefix,
MasterAddr: masterURL.Host,
MasterPrefix: api.Prefix,
KubernetesAddr: masterURL.Host,
KubernetesPrefix: server.DefaultLegacyAPIPrefix,
OAuthAuthorizeURI: oauthutil.OpenShiftOAuthAuthorizeURL(masterURL.String()),
OAuthTokenURI: oauthutil.OpenShiftOAuthTokenURL(masterURL.String()),
OAuthRedirectBase: c.Options.PublicURL,
OAuthClientID: OpenShiftWebConsoleClientID,
LogoutURI: c.Options.LogoutURL,
LoggingURL: c.Options.LoggingPublicURL,
MetricsURL: c.Options.MetricsPublicURL,
APIGroupAddr: masterURL.Host,
APIGroupPrefix: server.APIGroupPrefix,
MasterAddr: masterURL.Host,
MasterPrefix: api.Prefix,
KubernetesAddr: masterURL.Host,
KubernetesPrefix: server.DefaultLegacyAPIPrefix,
OAuthAuthorizeURI: oauthutil.OpenShiftOAuthAuthorizeURL(masterURL.String()),
OAuthTokenURI: oauthutil.OpenShiftOAuthTokenURL(masterURL.String()),
OAuthRedirectBase: c.Options.PublicURL,
OAuthClientID: OpenShiftWebConsoleClientID,
LogoutURI: c.Options.LogoutURL,
LoggingURL: c.Options.LoggingPublicURL,
MetricsURL: c.Options.MetricsPublicURL,
LimitRequestOverrides: c.LimitRequestOverrides,
}
kVersionInfo := kversion.Get()
oVersionInfo := oversion.Get()
Expand Down
52 changes: 51 additions & 1 deletion pkg/cmd/server/origin/asset_apiserver_adapter.go
Original file line number Diff line number Diff line change
@@ -1,14 +1,24 @@
package origin

import (
"os"

assetapiserver "github.com/openshift/origin/pkg/assets/apiserver"
configapi "github.com/openshift/origin/pkg/cmd/server/api"
"github.com/openshift/origin/pkg/cmd/util/pluginconfig"
override "github.com/openshift/origin/pkg/quota/admission/clusterresourceoverride"
overrideapi "github.com/openshift/origin/pkg/quota/admission/clusterresourceoverride/api"
)

// TODO this is taking a very large config for a small piece of it. The information must be broken up at some point so that
// we can run this in a pod. This is an indication of leaky abstraction because it spent too much time in openshift start
func NewAssetServerConfigFromMasterConfig(masterConfigOptions configapi.MasterConfig) (*assetapiserver.AssetServerConfig, error) {
ret, err := assetapiserver.NewAssetServerConfig(*masterConfigOptions.AssetConfig)
clusterResourceOverrideConfig, err := getResourceOverrideConfig(masterConfigOptions)
if err != nil {
return nil, err
}

ret, err := assetapiserver.NewAssetServerConfig(*masterConfigOptions.AssetConfig, clusterResourceOverrideConfig)
if err != nil {
return nil, err
}
Expand All @@ -21,3 +31,43 @@ func NewAssetServerConfigFromMasterConfig(masterConfigOptions configapi.MasterCo

return ret, nil
}

// All this ugly was removed in 3.9
// getResourceOverrideConfig looks in two potential places where ClusterResourceOverrideConfig can be specified
func getResourceOverrideConfig(masterConfig configapi.MasterConfig) (*overrideapi.ClusterResourceOverrideConfig, error) {
overrideConfig, err := checkForOverrideConfig(masterConfig.AdmissionConfig)
if err != nil {
return nil, err
}
if overrideConfig != nil {
return overrideConfig, nil
}
if masterConfig.KubernetesMasterConfig == nil { // external kube gets you a nil pointer here
return nil, nil
}
overrideConfig, err = checkForOverrideConfig(masterConfig.KubernetesMasterConfig.AdmissionConfig)
if err != nil {
return nil, err
}
return overrideConfig, nil
}

// checkForOverrideConfig looks for ClusterResourceOverrideConfig plugin cfg in the admission PluginConfig
func checkForOverrideConfig(ac configapi.AdmissionConfig) (*overrideapi.ClusterResourceOverrideConfig, error) {
overridePluginConfigFile, err := pluginconfig.GetPluginConfigFile(ac.PluginConfig, overrideapi.PluginName, "")
if err != nil {
return nil, err
}
if overridePluginConfigFile == "" {
return nil, nil
}
configFile, err := os.Open(overridePluginConfigFile)
if err != nil {
return nil, err
}
overrideConfig, err := override.ReadConfig(configFile)
if err != nil {
return nil, err
}
return overrideConfig, nil
}