Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.9] UPSTREAM: 60490: Volume deletion should be idempotent #18878

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Mar 7, 2018

Contains parts of #59756 with isAWSErrorVolumeNotFound() and describeVolumes() changes.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1548628

@tsmetana @gnufied, PTAL

Contains parts of #59756 with isAWSErrorVolumeNotFound() and
describeVolumes() changes.
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 7, 2018
@jsafrane jsafrane added this to the 3.9.0 milestone Mar 7, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Mar 7, 2018
@eparis eparis added kind/bug Categorizes issue or PR as related to a bug. queue/fix labels Mar 7, 2018
@eparis
Copy link
Member

eparis commented Mar 7, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2018
@mfojtik
Copy link
Contributor

mfojtik commented Mar 7, 2018

/retest

the network test is a known infra flake

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@gnufied
Copy link
Member

gnufied commented Mar 7, 2018

/test extended_networking_minimal

@eparis eparis removed the queue/fix label Mar 7, 2018
@gnufied
Copy link
Member

gnufied commented Mar 7, 2018

/test extended_networking_minimal

@openshift-ci-robot
Copy link

@jsafrane: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_networking_minimal 39b54e1 link /test extended_networking_minimal

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eparis eparis merged commit 2d1461a into openshift:release-3.9 Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants