Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor 'oc edit' output format #20589

Merged
merged 3 commits into from
Aug 13, 2018
Merged

Honor 'oc edit' output format #20589

merged 3 commits into from
Aug 13, 2018

Conversation

juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented Aug 9, 2018 •
edited
Loading

@juanvallejo
UPSTREAM: 66225: add support for "success" output for edit command
348f11a 
Adds support for the "success" printer in the "edit" command, while
ensuring outputFormat constraints for the in-editor printer.
@juanvallejo
UPSTREAM: 66225: update testcase for edit
0a3966e
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 9, 2018
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 9, 2018
@juanvallejo
Copy link
Contributor Author

/test cmd

@soltysh soltysh self-assigned this Aug 13, 2018
soltysh
soltysh approved these changes Aug 13, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2018
@soltysh
Copy link
Contributor

soltysh commented Aug 13, 2018

/retest

@soltysh soltysh added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 32de4f6 into openshift:master Aug 13, 2018
@juanvallejo juanvallejo deleted the jvallejo/pick-upstream-66225 branch August 29, 2018 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@tbielawa tbielawa Awaiting requested review from tbielawa

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juanvallejo @soltysh @openshift-ci-robot @openshift-merge-robot