remove oapi #21782

deads2k · 2019-01-14T18:07:27Z

realistically, I'm not going to get to this for a while.

@soltysh @sttts post-rebase I suppose,

soltysh · 2019-01-14T19:15:09Z

@soltysh @sttts post-rebase I suppose,

sgtm, I can pick that up by then

deads2k · 2019-01-29T13:37:42Z

rebased and ready for review. I expect we'll bump through a few more tests

mfojtik · 2019-01-29T13:39:50Z

/lgtm

openshift-bot · 2019-01-29T16:39:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-01-29T18:40:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

deads2k · 2019-01-29T19:27:21Z

bumped into containers/image#570 . I'll update our fork to unstick this pull to start.

openshift-bot · 2019-01-29T20:41:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2019-01-29T21:23:06Z

New changes are detected. LGTM label has been removed.

deads2k · 2019-01-29T23:55:19Z

@bparees is the e2e-aws-builds job currently in a good state? I may have missed a couple, but I thought I got everything under /test

deads2k · 2019-01-29T23:56:40Z

@bparees the e2e-aws-serial job openshift-tests [registry][Serial][Suite:openshift/registry/serial] Image signature workflow can push a signed image to openshift registry and verify it [Suite:openshift/conformance/serial] Where does it get its copy of containers/image? I've got a pull to update that repo (containers/image#570), but that test is going to break without getting a bump.

bparees · 2019-01-29T23:58:24Z

@bparees is the e2e-aws-builds job currently in a good state? I may have missed a couple, but I thought I got everything under /test

as far as i know, other than occasional flakes until the longrunning behavior for instantiate binary is restored..I think you guys have a PR for that but i'm not sure it's merged?

bparees · 2019-01-30T00:01:38Z

@deads2k you can ask @gabemontero about the pipeline test failures. i know he was fixing a flake but it's also possible the pipelines use oapi somewhere, up to and including the jenkins plugins themselves.

bparees · 2019-01-30T00:11:58Z

@bparees the e2e-aws-serial job openshift-tests [registry][Serial][Suite:openshift/registry/serial] Image signature workflow can push a signed image to openshift registry and verify it [Suite:openshift/conformance/serial] Where does it get its copy of containers/image? I've got a pull to update that repo (containers/image#570), but that test is going to break without getting a bump.

looks like the test itself runs an image w/ skopeo in it so probably we need an updated version of skopeo that has whatever fix you've done to go against the right signatures api?

bparees · 2019-01-30T00:19:51Z

@deads2k https://github.com/openshift/origin/blob/master/test/extended/testdata/signer-buildconfig.yaml#L21

and before you complaint to me about it:
#14124

gabemontero · 2019-01-30T02:33:08Z

@bparees @deads2k the https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/21782/pull-ci-openshift-origin-master-e2e-aws-builds/454 failures were unrelated to the flake fix I hope to have merged Tuesday AM

These failures were from the token (oc whoami -t result)for the non-admin user set up with the extended tests failing self-sar against the namespace of the jenkins pod

The login plugin is using these uri's:

    private static final String USER_URI = "/oapi/v1/users/~";
    private static final String SAR_URI = "/oapi/v1/subjectaccessreviews";

So yeah, seems like an oapi removal would have some impact.

And I see 404's trying to hit those uri's in the jenkins log.

So confirmed.

bparees · 2019-01-30T02:37:23Z

@gabemontero thanks, we'll have to queue up fixing that before this can merge. Do any of the other jenkins plugins use oapi?

openshift-ci-robot · 2019-01-30T19:29:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/api/OWNERS~~ [deads2k,mfojtik]
~~pkg/build/OWNERS~~ [deads2k,mfojtik]
~~pkg/cmd/OWNERS~~ [deads2k,mfojtik]
~~pkg/oauth/OWNERS~~ [deads2k,mfojtik]
~~pkg/oauthserver/OWNERS~~ [deads2k,mfojtik]
~~test/cmd/OWNERS~~ [deads2k,mfojtik]
~~test/extended/OWNERS~~ [deads2k,mfojtik]
~~test/integration/OWNERS~~ [deads2k,mfojtik]
~~vendor/k8s.io/kubernetes/staging/src/k8s.io/kube-aggregator/OWNERS~~ [deads2k,mfojtik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mtrmac · 2019-01-30T19:30:02Z

@bparees the e2e-aws-serial job openshift-tests [registry][Serial][Suite:openshift/registry/serial] Image signature workflow can push a signed image to openshift registry and verify it [Suite:openshift/conformance/serial] Where does it get its copy of containers/image? I've got a pull to update that repo (containers/image#570), but that test is going to break without getting a bump.

FWIW that test could be updated at

origin/test/extended/images/signatures.go

Line 102 in 8fa6f2f

"atomic:" + signedImage,

to use "docker://" instead of "atomic:" and it should continue to work (as long as the registry is ≥1.5.0-alpha.3); that would also allow removing the oc login call and the KUBERNETES_MASTER environment variable.

Of course none of this changes the fact that removing the namespace breaks all existing builds of skopeo when used with the atomic: transport.

deads2k · 2019-01-30T21:13:35Z

/retest

deads2k · 2019-01-30T21:16:22Z

/retest

gabemontero · 2019-01-30T21:46:31Z

e2e-aws-builds never got off the ground for https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/21782/pull-ci-openshift-origin-master-e2e-aws-builds/484

gabemontero · 2019-01-30T21:46:42Z

/test e2e-aws-builds

soltysh · 2019-01-31T13:10:29Z

So I'm guessing you need #21921 to land which picks up the new new containers in vendor.

deads2k · 2019-01-31T15:58:25Z

/retest

deads2k · 2019-01-31T23:50:33Z

@gabemontero one more: https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/21782/pull-ci-openshift-origin-master-e2e-aws-builds/527

known flake?

bparees · 2019-02-01T00:56:40Z

I think gabe was seeing some slowness today, yes.. i just had a successful aws-builds job run on another PR, so let's retry here.

/test e2e-aws-builds

soltysh · 2019-02-01T12:24:27Z

CI failure
/retest

deads2k · 2019-02-01T14:28:25Z

spoke with @bparees and @gabemontero the single failing build test does not appear to be related to this change and keeping the signal for changes to builds is valuable. We will manually merge this and watch the results today.

mtrmac · 2019-02-02T02:23:26Z

test/extended/images/signatures.go

@@ -22,6 +22,7 @@ var _ = g.Describe("[registry][Serial][Suite:openshift/registry/serial] Image si
 	)

 	g.It("can push a signed image to openshift registry and verify it", func() {
+		g.Skip("disable because containers/image: https://github.com/containers/image/pull/570")


#21782 (comment) ?

cben · 2019-05-19T11:14:40Z

Good riddance 👏 🎉.

Out of curiously, has this been publicly announced somewhere (ahead of 4.0 changelogs)?
I'll have some work to adapt ManageIQ code using openshift apis, and would have liked to learn of this earlier. Is there some public channel for "Openshift API users" to subscribe to?
(I also work in redhat, and I see there were emails I missed in the noise 😉, but I'm asking upstream angle...)

(Used "Red Hat-Managed" option, which is presently hidden for most external users - it's partially, but not yet fully, what one will get in OpenShift Dedicated 4.1. May differ slightly from self-installed OCP?) env DIR=openshift-4.1.0-rc.3 URL="https://api.cben-oapi.bexf.p1.openshiftapps.com:6443" WAIT_OKS="healthz readyz" tools/scrape.sh --insecure - Notably /oapi is completely gone now! (openshift/origin#21782) - TODO: /version/openshift no longer available (openshift/origin#21434) Probably need to scrape `oc get clusterversion` operator CR?

- Use docker:// instead of atomic:, as recommended back in openshift#21782 (comment) openshift#21782 (comment) - Then re-enable the test Signed-off-by: Miloslav Trmač <mitr@redhat.com>

- Use docker:// instead of atomic:, as recommended back in openshift#21782 (comment) openshift#21782 (comment) Signed-off-by: Miloslav Trmač <mitr@redhat.com>

openshift-ci-robot requested review from mrogers950 and soltysh January 14, 2019 18:07

deads2k force-pushed the remove-oapi branch from 4960846 to 53288d4 Compare January 29, 2019 13:37

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 29, 2019

deads2k changed the title ~~[WIP] remove oapi~~ remove oapi Jan 29, 2019

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2019

openshift-ci-robot assigned mfojtik Jan 29, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2019

deads2k force-pushed the remove-oapi branch from 53288d4 to 804ab14 Compare January 29, 2019 21:23

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2019

disable image verify test for out of date containers/image

168d3b4

deads2k force-pushed the remove-oapi branch from 804ab14 to 168d3b4 Compare January 30, 2019 19:29

deads2k added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2019

deads2k merged commit c593f42 into openshift:master Feb 1, 2019

mtrmac reviewed Feb 2, 2019

View reviewed changes

This was referenced Feb 20, 2019

lib/rest_openshift.rb self.populate update openshift/verification-tests#85

Closed

fix oapi, which has become obsolete in 4.0 openshift/verification-tests#84

Closed

This was referenced May 19, 2019

Add support for OpenShift 4.0 ManageIQ/manageiq-providers-openshift#139

Closed

OpenShift support will break with OpenShift 4.0. jupyterhub/oauthenticator#252

Closed

cben mentioned this pull request May 19, 2019

Discovery info for processedtemplates & templates both have kind: Template #21668

Open

mtrmac mentioned this pull request Feb 10, 2021

Fix and re-enable test/extended/images/signatures.go #25880

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove oapi #21782

remove oapi #21782

deads2k commented Jan 14, 2019

soltysh commented Jan 14, 2019

deads2k commented Jan 29, 2019

mfojtik commented Jan 29, 2019

openshift-bot commented Jan 29, 2019

openshift-bot commented Jan 29, 2019

deads2k commented Jan 29, 2019

openshift-bot commented Jan 29, 2019

openshift-ci-robot commented Jan 29, 2019

deads2k commented Jan 29, 2019

deads2k commented Jan 29, 2019

bparees commented Jan 29, 2019

bparees commented Jan 30, 2019

bparees commented Jan 30, 2019

bparees commented Jan 30, 2019

gabemontero commented Jan 30, 2019 •

edited

Loading

bparees commented Jan 30, 2019

openshift-ci-robot commented Jan 30, 2019

mtrmac commented Jan 30, 2019

deads2k commented Jan 30, 2019

deads2k commented Jan 30, 2019

gabemontero commented Jan 30, 2019

gabemontero commented Jan 30, 2019

soltysh commented Jan 31, 2019

deads2k commented Jan 31, 2019

deads2k commented Jan 31, 2019

bparees commented Feb 1, 2019

soltysh commented Feb 1, 2019

deads2k commented Feb 1, 2019

mtrmac Feb 2, 2019

cben commented May 19, 2019

remove oapi #21782

remove oapi #21782

Conversation

deads2k commented Jan 14, 2019

soltysh commented Jan 14, 2019

deads2k commented Jan 29, 2019

mfojtik commented Jan 29, 2019

openshift-bot commented Jan 29, 2019

openshift-bot commented Jan 29, 2019

deads2k commented Jan 29, 2019

openshift-bot commented Jan 29, 2019

openshift-ci-robot commented Jan 29, 2019

deads2k commented Jan 29, 2019

deads2k commented Jan 29, 2019

bparees commented Jan 29, 2019

bparees commented Jan 30, 2019

bparees commented Jan 30, 2019

bparees commented Jan 30, 2019

gabemontero commented Jan 30, 2019 • edited Loading

bparees commented Jan 30, 2019

openshift-ci-robot commented Jan 30, 2019

mtrmac commented Jan 30, 2019

deads2k commented Jan 30, 2019

deads2k commented Jan 30, 2019

gabemontero commented Jan 30, 2019

gabemontero commented Jan 30, 2019

soltysh commented Jan 31, 2019

deads2k commented Jan 31, 2019

deads2k commented Jan 31, 2019

bparees commented Feb 1, 2019

soltysh commented Feb 1, 2019

deads2k commented Feb 1, 2019

mtrmac Feb 2, 2019

Choose a reason for hiding this comment

cben commented May 19, 2019

gabemontero commented Jan 30, 2019 •

edited

Loading