-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "UPSTREAM: 71804: Use UnmountMountPoint util to clean up subpaths" #22412
Revert "UPSTREAM: 71804: Use UnmountMountPoint util to clean up subpaths" #22412
Conversation
Also CC @jsafrane, @bertinatto. Not sure what I need to do about Travis:
Anyone who does is welcome to fix my commit or create their own reverting PR to unstick CI. |
Not much on why? /test integration |
@wking, commit message must be in format |
/approve |
Can you force-push to my branch or create a new PR? I'm restricted to GitHub's web UI for the next few hours, and they still don't seem to support amending commit messages. |
70c226c
to
996e759
Compare
Force pushed. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jsafrane, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reverts #22396
This is leading to many, many CI failures, including all of the nine runs of https://testgrid.k8s.io/redhat-openshift-release-blocking#redhat-release-openshift-origin-installer-e2e-aws-4.0&sort-by-flakiness= since the test was added. Revert to get us going again while we look into why.
CC @wongma7, @jwforres, @abhinavdahiya