Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "UPSTREAM: 71804: Use UnmountMountPoint util to clean up subpaths" #22412

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

wking
Copy link
Member

@wking wking commented Mar 27, 2019

Reverts #22396

This is leading to many, many CI failures, including all of the nine runs of https://testgrid.k8s.io/redhat-openshift-release-blocking#redhat-release-openshift-origin-installer-e2e-aws-4.0&sort-by-flakiness= since the test was added. Revert to get us going again while we look into why.

CC @wongma7, @jwforres, @abhinavdahiya

@wking
Copy link
Member Author

wking commented Mar 27, 2019

Also CC @jsafrane, @bertinatto. Not sure what I need to do about Travis:

The following commits contain vendor changes but aren't declared as UPSTREAM or bump(*) commits:

Anyone who does is welcome to fix my commit or create their own reverting PR to unstick CI.

@wking
Copy link
Member Author

wking commented Mar 27, 2019

integration:

FAIL: github.com/openshift/origin/test/integration/runner TestIntegration/TestImageStreamImportRedHatRegistry 4m53.93s
FAIL: github.com/openshift/origin/test/integration/runner TestIntegration 60ms

Not much on why?

/test integration

@jsafrane
Copy link
Contributor

The following commits contain vendor changes but aren't declared as UPSTREAM or bump(*) commits:

@wking, commit message must be in format UPSTREAM: 71804: revert ...

@jsafrane
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2019
@wking
Copy link
Member Author

wking commented Mar 27, 2019

commit message must be in format UPSTREAM: 71804: revert ...

Can you force-push to my branch or create a new PR? I'm restricted to GitHub's web UI for the next few hours, and they still don't seem to support amending commit messages.

@jsafrane jsafrane force-pushed the revert-22396-fix-gluster-stale-mount branch from 70c226c to 996e759 Compare March 27, 2019 10:10
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2019
@jsafrane
Copy link
Contributor

Force pushed.

@bertinatto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 918f340 into master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants