Fixed jenkins verifyservice e2e tests #23581
Conversation
openshift-ci-robot
added
the
size/L
|
/assign @akram |
|
/assign @adambkaplan |
waveywaves
force-pushed
the
e2etests/jenkins-client-plugin/verifyservice
branch
from
b4220c2
to
1c845e9
Compare
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
| err = oc.AsAdmin().Run("delete").Args("all", "-l", "app=nodejs-example").Execute() | ||
| err = oc.AsAdmin().Run("delete").Args("all", "-l", fmt.Sprintf("app=%v", redisTemplate)).Execute() |
There was a problem hiding this comment.
this one should be redisAppName not redisTemplate.
| - apiVersion: v1 | ||
| kind: BuildConfig | ||
| metadata: | ||
| name: jenkins-verifyservice-pipeline | ||
| app: redis-ephemeral |
There was a problem hiding this comment.
All the other components will be create with app=redis and not app=redis-ephemeral
|
/approve |
|
yeah adding the test data will require @adambkaplan (perhaps another candidate for OWNERS update) |
|
@waveywaves there is an error with your changes in the latest e2e-aws-builds run ... I'll refrain from highlighting it for now ... see if you can sort it out. |
|
/hold still other issues that needs to be fixed, I pinged @waveywaves |
openshift-ci-robot
added
the
do-not-merge/hold
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
| redisTemplate := "redis-ephemeral" | ||
| redisAppName := "redis" | ||
| newAppRedisEphemeralArgs := []string{"--template", fmt.Sprintf("--name=%v", redisAppName), redisTemplate, "-p", "MEMORY_LIMIT=128Mi"} |
There was a problem hiding this comment.
The syntax is not correct, it should be:
newAppRedisEphemeralArgs := []string{ fmt.Sprintf("--template=%v", redisTemplate), fmt.Sprintf("--name=%v", redisAppName), "-p", "MEMORY_LIMIT=128Mi"}
or simplier:
newAppRedisEphemeralArgs := []string{ redisTemplate, "--name", redisAppName), "-p", "MEMORY_LIMIT=128Mi"}
waveywaves
force-pushed
the
e2etests/jenkins-client-plugin/verifyservice
branch
from
1c845e9
to
8b5986d
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/test e2e-cmd |
|
/test e2e-aws-serial |
|
/lgtm |
|
/approve |
|
/assign @adambkaplan |
|
/assign @bparees As of @adambkaplan is on PTO, can you approve this one ? |
|
/approve but i would like to understand this:
why was the original nodejs image crashlooping? was the nodejs image changed such that it can no longer be run without source code being added? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akram, bparees, gabemontero, waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
It is an S2I image with no source code and nothing defined as the entrypoint. To make the container run with the image, commands need ot be given in the Deployment. Hence we had to fall bakc to using a predefined template. |
yes but presumably this test was working at some point, so why did it start failing? |
After testing out the deployment config seperately, it did fail with a crashloopback off. When the changes were pushed to github, the tests which ran did not fail (keep in mind these are not the new ones) and seems like changes in these tests weren't picked up by the CI unlike travisCI where the changes in the PR are applied to the test env. After the last PR with the changes in origin/test/extended/... was merged, only after that the new tests started to run ad we were able to confirm that there is something wrong with the tests themselves after which we fixed it. |
|
hm. i'm still a little puzzled but it sounds like this test basically wasn't being run normally so we didn't notice it was broken. |
Fixed as containers were going to crashloopbackoff.
The image loaded before was an s2i image without the source.
In this iteration we are using the redis-epemeral template with reduced memory which also provides us with the basic service to test and in the template jenkins-verifyservice-pipeline we are creating the headless service and the buildconfig with the jenkins file to test the feature.
cc @akram @gabemontero