-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1739603: UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods [4.1] #23584
Bug 1739603: UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods [4.1] #23584
Conversation
@sjenning: This pull request references an invalid Bugzilla bug:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@sjenning: This pull request references a valid Bugzilla bug. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
This PR requires review/lgtm/approval from the engineering team |
/lgtm
/approve
…On Sat, Aug 24, 2019 at 3:08 PM Eric Paris ***@***.***> wrote:
This PR requires review/lgtm/approval from the engineering team
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#23584?email_source=notifications&email_token=ABPR23AVMAHSRJFJTTAHZJTQGGBLVA5CNFSM4IKVHWK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CFZPY#issuecomment-524573887>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABPR23EETRUNYWCVQJDKXNLQGGBLVANCNFSM4IKVHWKQ>
.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@sjenning: All pull requests linked via external trackers have merged. Bugzilla bug 1739603 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
upstream PR kubernetes/kubernetes#80491
master PR #23576
@derekwaynecarr @mrunalp