-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: images.sh: Do not rely on the tag order #29104
Conversation
@ardaguclu: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ardaguclu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Once this https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/29104/pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd/1834562450733666304 passes, this PR is ready to merge. |
/test e2e-agnostic-ovn-cmd |
af36cf5
to
fcbbb59
Compare
fcbbb59
to
d35f49c
Compare
/test ci/prow/unit |
@ardaguclu: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test unit |
This revert #29105 should fix it; |
@ardaguclu: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ardaguclu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ImageStreams object's tag order seems to be changed and this test fully relies on the first object of the tag list and it is perma-failing https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_oc/1877/pull-ci-openshift-oc-master-e2e-agnostic-ovn-cmd/1834521049262198784. This PR modifies the test by searching for the perl 5.32 image in the list instead of checking the first item.