Add new featuregate test to check if desired.Architecture is set as intended #29808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Prashanth684 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-gcp-ovn-techpreview-serial |
|
/test e2e-gcp-ovn-techpreview |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 9d53ca0
New tests seen in this PR at sha: 9d53ca0
|
wking
reviewed
May 27, 2025
| @@ -0,0 +1,5 @@ | |||
| reviewers: | |||
| - cluster-version-operator-test-case-reviewers | |||
There was a problem hiding this comment.
Our existing consumer for this alias is in test/extended/util/openshift/clusterversionoperator. I'm not all that clear on how test/extended is organized, but it seems like we should keep these CVO-functionality tests collected in the same directory?
There was a problem hiding this comment.
wking
reviewed
May 27, 2025
wking
reviewed
May 27, 2025
…ntended A new featuregated field was introduced a while ago under clusterversion status - `desired.Architecture` which denotes the architecture of the release image being reconciled to. As we plan to promote the feature gate to default - this adds a basic test to check if the `desired.Architecture` is set based on the `release.openshift.io/architecture: multi` being present as part of the release metadata.
Prashanth684
force-pushed
the
4552-cvo-test
branch
from
9d53ca0 to
bca8bc2
Compare
|
/retest-required |
|
@Prashanth684: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cc |
|
/test e2e-gcp-ovn-techpreview-serial |
|
@Prashanth684: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-gcp-ovn-techpreview |
|
Job Failure Risk Analysis for sha: bca8bc2
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: bca8bc2
New tests seen in this PR at sha: bca8bc2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new featuregated field was introduced a while ago under clusterversion status -
desired.Architecturewhich denotes the architecture of the release image being reconciled to. As we plan to promote the feature gate to default - this adds a basic test to check if thedesired.Architectureis set based on therelease.openshift.io/architecture: multibeing present as part of the release metadata.