Allow non-drained updates based on node schedulability and kubelet status #30477
Conversation
…atus The previous PR (openshift#30318) allowed non-drained updates but also required the node annotation "machineconfiguration.openshift.io/state"="Done". This condition is too strict, as the MCD may not be in the "Done" state when the nodes remain schedulable and fully functional. Signed-off-by: Qi Wang <qiwan@redhat.com>
|
/testwith openshift/cluster-update-keys/main/e2e-aws-upgrade openshift/cluster-update-keys#85 #30477 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: QiWang19 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@QiWang19: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Close in favor of #30480 |
1 participant
The previous PR (#30318) allowed non-drained updates but also required the node annotation
"machineconfiguration.openshift.io/state": "Done". This condition is too strict, as the MCD may not be in the "Done" state when the nodes remain schedulable and fully functional.