Skip to content

[release-4.21] OCPBUGS-74373: Remove restriction of unmanaged x-k8s.io #30718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
openshift-cherrypick-robot wants to merge 1 commit into
base: release-4.21
Choose a base branch
from
Open

[release-4.21] OCPBUGS-74373: Remove restriction of unmanaged x-k8s.io #30718

openshift-cherrypick-robot wants to merge 1 commit into from
+7 −9

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jan 22, 2026

This is an automated cherry-pick of #30658

/assign rikatz

@rikatz
NE-2376: Remove restriction of unmanaged x-k8s.io
4b960cc 
Previously, cluster-ingress-operator would manage and block any
    updates to CRDs that were from group gateway.networking.x-k8s.io.

    After some analysis we identified that OSSM/Istio does filter these
    resources in case it does not have a flag to enable alpha APIs, which means
    it is safe to allow users to deploy these CRDs.

    This way, this change removes any restriction on x-k8s.io group,
    and removes any further reconciliation from CIO on x-k8s.io group.

Signed-off-by: Ricardo Pchevuzinske Katz <katz@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 22, 2026
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 22, 2026 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: NE-2376

Details

In response to this:

This is an automated cherry-pick of #30658

/assign rikatz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rikatz
Copy link
Member

rikatz commented Jan 22, 2026

/lgtm
/approve
/cc @Miciah

@openshift-ci openshift-ci bot requested a review from Miciah January 22, 2026 22:10
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Miciah
Copy link
Contributor

Miciah commented Jan 22, 2026

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, openshift-cherrypick-robot, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2026
@Miciah
Copy link
Contributor

Miciah commented Jan 22, 2026

This is a low-risk backport. It changes tests to loosen restrictions on creating Gateway API CRDs in the x-k8s.io group, which the platform does not install and which our gateway controller would ignore if they were installed.

/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

@Miciah: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers]

Details

In response to this:

This is a low-risk backport. It changes tests to loosen restrictions on creating Gateway API CRDs in the x-k8s.io group, which the platform does not install and which our gateway controller would ignore if they were installed.

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Miciah
Copy link
Contributor

Miciah commented Jan 22, 2026

@knobunc, can you add the "backport-risk-assessed" and "jira/valid-bug" labels?

@Miciah
Copy link
Contributor

Miciah commented Jan 22, 2026

We will also need the same labels on #30717 and #30719.

@knobunc
Copy link
Contributor

knobunc commented Jan 23, 2026

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 23, 2026
@knobunc
Copy link
Contributor

knobunc commented Jan 23, 2026

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 23, 2026
@rikatz
Copy link
Member

rikatz commented Jan 23, 2026

/retitle [release-4.21] OCPBUGS-74373: Remove restriction of unmanaged x-k8s.io

@openshift-ci openshift-ci bot changed the title [release-4.21] NE-2376: Remove restriction of unmanaged x-k8s.io [release-4.21] OCPBUGS-74373: Remove restriction of unmanaged x-k8s.io Jan 23, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 23, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 23, 2026

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-74373, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-74373 to depend on a bug targeting a version in 4.22.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #30658

/assign rikatz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 23, 2026
@rikatz
Copy link
Member

rikatz commented Jan 23, 2026

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 23, 2026

@rikatz: This pull request references Jira Issue OCPBUGS-74373, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-74373 to depend on a bug targeting a version in 4.22.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rikatz
Copy link
Member

rikatz commented Jan 23, 2026

/hold

@Miciah will wait to open a parent bug for this backport, we can discuss this on Monday morning.

@knobunc thanks for the approval!

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alebedev87 alebedev87 Awaiting requested review from alebedev87

@rfredette rfredette Awaiting requested review from rfredette

@Miciah Miciah Awaiting requested review from Miciah

Assignees

@dgoodwin dgoodwin

@adambkaplan adambkaplan

@rikatz rikatz

@kasturinarra kasturinarra

@Moebasim Moebasim

@jadhaj jadhaj

@lyman9966 lyman9966

@pamoedom pamoedom

@gangwgr gangwgr

@prabhapa prabhapa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.