Skip to content

CNTRLPLANE-2622: filter out check-endpoints-config events from test#30785

Open
ricardomaraschini wants to merge 1 commit intoopenshift:mainfrom
ricardomaraschini:CNTRLPLANE-2622
Open

CNTRLPLANE-2622: filter out check-endpoints-config events from test#30785
ricardomaraschini wants to merge 1 commit intoopenshift:mainfrom
ricardomaraschini:CNTRLPLANE-2622

Conversation

@ricardomaraschini
Copy link
Contributor

@ricardomaraschini ricardomaraschini commented Feb 13, 2026

As part of the PQC work, we detected that the "check-endpoints" container in the kube-apiserver pod does not respect the TLS security profile. To address this, we created a PR , which introduces a new "non-optional" ConfigMap to hold the "check-endpoints" container config. This works well, but we encountered an alert during the upgrade test. After investigation, we believe this spike in "RequiredInstallerResourcesMissing" for the new ConfigMap is expected, and this is what this PR is about (we will be ignoring events regarding this new "non-optional" ConfigMap).

Our assessment is that the "target configuration" controller takes some time to create the new ConfigMap, and then the "revision controller" needs additional time to create a new revision. During this window, the "installer controller" validates the currently deployed revision (created by the old operator) against the new operator's in-memory resource requirements, which now include a ConfigMap that was never part of that revision, causing validation to fail.

I am available to discuss this further.

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 13, 2026
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2026

@ricardomaraschini: This pull request references CNTRLPLANE-2622 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

the check-endpoints-config configmap was introduced in 4.22, causing a temporary expected surge of RequiredInstallerResourcesMissing events during upgrades tests from 4.21. this commit proposes to remove these events off as they are transient and go away after a while.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ricardomaraschini
Once this PR has been reviewed and has the lgtm label, please assign petr-muller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ricardomaraschini
Copy link
Contributor Author

/test all

the check-endpoints-config configmap was introduced in 4.22, causing
a temporary expected surge of RequiredInstallerResourcesMissing events
during upgrades tests from 4.21. this commit proposes to remove these
events off as they are transient and go away after a while.
@ricardomaraschini
Copy link
Contributor Author

/test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2026

@ricardomaraschini: This pull request references CNTRLPLANE-2622 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

As part of the PQC work, we detected that the "check-endpoints" container in the kube-apiserver pod does not respect the TLS security profile. To address this, we created a PR , which introduces a new "non-optional" ConfigMap to hold the "check-endpoints" container config. This works well, but we encountered an alert during the upgrade test. After investigation, we believe this spike in "RequiredInstallerResourcesMissing" for the new ConfigMap is expected, and this is what this PR is about (we will be ignoring events regarding this new "non-optional" ConfigMap).

Our assessment is that the "target configuration" controller takes some time to create the new ConfigMap, and then the "revision controller" needs additional time to create a new revision. During this window, the "installer controller" validates the currently deployed revision (created by the old operator) against the new operator's in-memory resource requirements, which now include a ConfigMap that was never part of that revision, causing validation to fail.

I am available to discuss this further.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ricardomaraschini ricardomaraschini marked this pull request as ready for review February 18, 2026 12:31
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2026
@ricardomaraschini
Copy link
Contributor Author

/unhold

@ricardomaraschini
Copy link
Contributor Author

Hi @dgoodwin , I am assigning this to you as you seem to be one that understands the context behind this test for RequiredInstallerResourcesMissing events. Would you mind taking a look at this and let me know if you think this is reasonable ?

/assign @dgoodwin

@ricardomaraschini
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2026

@ricardomaraschini: This pull request references CNTRLPLANE-2622 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial February 18, 2026 12:48
@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@ricardomaraschini
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 19, 2026

@ricardomaraschini: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-fips f6b9e83 link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-serial-2of2 f6b9e83 link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-gcp-ovn-upgrade f6b9e83 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 f6b9e83 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments