[WIP] Build hooks proposal #3736
Conversation
|
|
||
| As an application developer, I want to be notified or notify other people after | ||
| a build completes, email or otherwise, including the build result (success or | ||
| failure). |
There was a problem hiding this comment.
I also want information about the thing that was built (eg what's the imageid so i can explicitly pull/inspect the image that was produced)
There was a problem hiding this comment.
Will include it.
I have it in mind as a part that was not covered yet, which is determining the "signature" of the hooks -- what are the inputs passed to the hooks and what output can/should a hook return apart from side effects.
There was a problem hiding this comment.
BTW -- do we have any real use case for consuming the image ID, or is it just something we believe might be useful?
There was a problem hiding this comment.
If you need to report it to a webhook. If you trigger something based on a
build completing, not being able to exactly use the output of the build is
unacceptable (ie it's a bug if you can't get the correct image).
On Jul 16, 2015, at 5:20 PM, Rodolfo Carvalho notifications@github.com
wrote:
In docs/proposals/build-hooks.md
#3736 (comment):
+## Use cases
+
+### 1. Build pipeline
+
+As an application developer, I want to be able to trigger a build after an
+upstream build completes,
+creating a build pipeline.
+
+
+### 2. Integration with external system
+
+As an application developer, I want to be notified or notify other people after
+a build completes, email or otherwise, including the build result (success or
+failure).
BTW -- do we have any real use case for consuming the image ID, or is it
just something we believe might be useful?
—
Reply to this email directly or view it on GitHub
https://github.com/openshift/origin/pull/3736/files#r34839212.
There was a problem hiding this comment.
+As an application developer, I want to be notified or notify other people after
+a build completes, email or otherwise, including the build result (success or
+failure).If you need to report it to a webhook. If you trigger something based on a
build completing, not being able to exactly use the output of the build is
unacceptable (ie it's a bug if you can't get the correct image).
This section was updated to include the Docker image ID that was built.
|
Closing this as we decided not to implement build hooks now. |
First draft of the proposal, want to run it by @smarterclayton and @bparees for discussion.
@mfojtik @mnagy FYI